-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specializing Operators.op_UnaryPlus for witness info #9769
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good but there is still a failure in the type provider test.
I think adding |
Ok, I managed to figure it out without adding to the public API. Basically, |
* Initial work to fix op_UnaryPlus witness info * Added UnaryPlusDynamic * update surface area * Only enable type provider test on net472 * Removing UnaryPlusDynamic * fixing build * fix comment * Update prim-types.fs
I got an internal compiler error when trying to compile one of the "hello world" test type providers under the preview flag. The error described that
op_UnaryPlus
had no witness info.Upon investigation, we didn't add an
UnaryPlusDynamic
function to handle the witness info creation inTcGlobals
.Two ways to handle it:
UnaryPlusDynamic
public API so it will be picked up when looking for built-in witness infosor
op_UnaryPlus
call toid
function for built-in witness info