Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test delaying startup code to the test it belongs to #17612

Merged
merged 2 commits into from
Aug 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ let compileAValidScenario (scenario: Scenario) (method: Method) =
let cUnit =
let files =
scenario.Files
|> Array.map (fun (f: FileInScenario) -> SourceCodeFileKind.Create(f.FileWithAST.File, f.Content))
|> Array.toList
|> List.map (fun (f: FileInScenario) -> SourceCodeFileKind.Create(f.FileName, f.Content))

match files with
| [] -> failwith "empty files"
Expand All @@ -44,7 +43,7 @@ let compileAValidScenario (scenario: Scenario) (method: Method) =
|> shouldSucceed
|> ignore

let scenarios = codebases |> List.map (fun c -> [| box c |]) |> Array.ofList
let scenarios = scenarios |> List.map (fun c -> [| box c |])

[<Theory>]
[<MemberData(nameof scenarios)>]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,17 @@ open NUnit.Framework
open FSharp.Compiler.GraphChecking
open Scenarios

let scenarios = codebases

[<TestCaseSource(nameof scenarios)>]
let ``Supported scenario`` (scenario: Scenario) =
let files = scenario.Files |> Array.map (fun f -> TestFileWithAST.Map f.FileWithAST)
let files =
scenario.Files
|> List.map (fun f ->
{Idx = f.Index; FileName = f.FileName; ParsedInput = parseSourceCode(f.FileName, f.Content)})
|> List.toArray
let filePairs = FilePairMap(files)
let graph, _trie = DependencyResolution.mkGraph filePairs files

for file in scenario.Files do
let expectedDeps = file.ExpectedDependencies
let actualDeps = set graph.[file.FileWithAST.Idx]
Assert.AreEqual(expectedDeps, actualDeps, $"Dependencies don't match for {System.IO.Path.GetFileName file.FileWithAST.File}")
let actualDeps = set graph.[file.Index]
Assert.AreEqual(expectedDeps, actualDeps, $"Dependencies don't match for {System.IO.Path.GetFileName file.FileName}")
Original file line number Diff line number Diff line change
Expand Up @@ -2,41 +2,36 @@

open TestUtils

type FileInScenario =
{
Index: int
FileName: string
ExpectedDependencies: Set<int>
Content: string
}

type Scenario =
{
Name: string
Files: FileInScenario array
Files: FileInScenario list
}

override x.ToString() = x.Name

and FileInScenario =
{
FileWithAST: TestFileWithAST
ExpectedDependencies: Set<int>
Content: string
}

let private scenario name files =
let files = files |> List.toArray |> Array.mapi (fun idx f -> f idx)
let files = files |> List.mapi (fun idx f -> f idx)
{ Name = name; Files = files }

let private sourceFile fileName content (dependencies: Set<int>) =
fun idx ->
let fileWithAST =
{
Idx = idx
AST = parseSourceCode (fileName, content)
File = fileName
}

{
FileWithAST = fileWithAST
Index = idx
FileName = fileName
ExpectedDependencies = dependencies
Content = content
}

let internal codebases =
let internal scenarios =
[
scenario
"Link via full open statement"
Expand Down
Loading