Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing a dead bench notebook #16496

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Removing a dead bench notebook #16496

merged 1 commit into from
Jan 5, 2024

Conversation

psfinaki
Copy link
Member

@psfinaki psfinaki commented Jan 4, 2024

This was added here but got broken during the refactoring here.

Now, this could be resurrected but I propose to just remove it, because:

  • it's not trivial to fix (code needs to be rewritten via the benchmark helpers to avoid duplication
  • it's not trivial to maintain (notebooks don't compile like other benchmarks we have)
  • it's not trivial to execute in CI
  • it's not very futureproof (as of now, the artifact paths and the code itself is broken)
  • it's not very useful (just a graph representation of the BDN table - we can those in all the FCS benchmarks)
  • it's not very original (as opposed to the historical benchmark for example)
  • it's not the right place (such things are likely better suited for dontet/perf repo)

@psfinaki psfinaki requested a review from a team as a code owner January 4, 2024 16:22
Copy link
Contributor

github-actions bot commented Jan 4, 2024

✅ No release notes required

@psfinaki psfinaki enabled auto-merge (squash) January 4, 2024 17:33
@psfinaki psfinaki merged commit 0cca686 into main Jan 5, 2024
27 checks passed
@psfinaki psfinaki deleted the bench/7 branch January 8, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants