Bugfix: Consuming [CliEvent] events from C#, if there are multiple types in a module and ref assemblies are used. #16218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarfgp
approved these changes
Nov 2, 2023
vzarytovskii
approved these changes
Nov 2, 2023
abonie
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14996 .
The issue was caused by reference assembly generation, which is on by default for net7+, and was not on for
<TargetFramework>6.0</..>.The fix addresses the issue with ordering of operations in ilwrite that depend on a read/write shared state (cenv).
Visual proof of the wrong codegen before for two types, each having 1 event.
Error is that codegen puts both events into one type, instead of one event for each:
After the fix,
+=from C# works as everything is codegen'd at the right type: