Code

AddExplicitReturnType refactoring#16077

Code

Merged

T-Gro merged 63 commits intodotnet:maindotnet/fsharp:mainfrom SebastianAtWork:features/codefix-return-typeSebastianAtWork/fsharp:features/codefix-return-typeCopy head branch name to clipboardDec 19, 2023

+736

Commits

Commits on Dec 1, 2023

• First Draft for AddExplicitReturnType (dotnet#15562) with exploration test and resource file entry

  SebastianAtWork

  committed
  e27012e

  Copy full SHA for e27012e

• Added Workspace handling and some debug stuff dotnet#15562

  SebastianAtWork

  committed
  b0fbe67

  Copy full SHA for b0fbe67

• Added One Way of getting the changed Solution for ExplicitReturnTypes dotnet#15562

  SebastianAtWork

  committed
  81d8f0e

  Copy full SHA for 81d8f0e

• added language resource files (not translated) dotnet#15562

  SebastianAtWork

  committed
  25b901e

  Copy full SHA for 25b901e

• refactor: Create test context and check return type

  SebastianAtWork

  committed
  c9baeda

  Copy full SHA for c9baeda

• refactor: Add explicit return type in FSharp.Editor.Tests/Refactors/AddExplicitReturnType.fs

  Show description for 42d67f5
  SebastianAtWork

  committed
  42d67f5

  Copy full SHA for 42d67f5

• feat: Add function to get return type of symbol

  Show description for 493b374
  SebastianAtWork

  committed
  493b374

  Copy full SHA for 493b374

• refactor: Remove explicit return type annotation

  Show description for 12d76d4
  SebastianAtWork

  committed
  12d76d4

  Copy full SHA for 12d76d4

• chore: committed resources

  SebastianAtWork

  committed
  b22a519

  Copy full SHA for b22a519

• * test(FSharp.Editor.Tests): finally got a working test for remove epxlicit return type

  SebastianAtWork

  committed
  a14c048

  Copy full SHA for a14c048

• 🚀feat(tests) add F# editor refactoring tests

  Show description for 7b31775
  SebastianAtWork

  committed
  7b31775

  Copy full SHA for 7b31775

• fix: formatting

  SebastianAtWork

  committed
  83bfb1e

  Copy full SHA for 83bfb1e

• * refactor(FSharp.Editor): improve explicit return type removal

  Show description for da2dc25
  SebastianAtWork

  committed
  da2dc25

  Copy full SHA for da2dc25

• * feat(FSharp.Editor): add RangeOfReturnTypeDefinition and refactor methods in RemoveExplicitReturnType.fs

  Show description for 7c4f039
  SebastianAtWork

  committed
  7c4f039

  Copy full SHA for 7c4f039

• * refactor(FSharp.Editor.Tests): simplify and improve test code readability

  Show description for 9e31a4e
  SebastianAtWork

  committed
  9e31a4e

  Copy full SHA for 9e31a4e

• fix: remove debug lines

  SebastianAtWork

  committed
  1df0308

  Copy full SHA for 1df0308

• * refactor(FSharp.Editor.Tests): improve test method names and assertions

  Show description for fefe14b
  SebastianAtWork

  committed
  fefe14b

  Copy full SHA for fefe14b

• * feat(FSharp.Editor): add InternalOptionBuilder module

  Show description for 7cf8ab0
  SebastianAtWork

  committed
  7cf8ab0

  Copy full SHA for 7cf8ab0

• * refactor(FSharp.Editor): simplify async tasks in AddExplicitReturnType and RemoveExplicitReturnType

  Show description for 0c306a3
  SebastianAtWork

  committed
  0c306a3

  Copy full SHA for 0c306a3

• * feat(FSharp.Editor): update condition for return type hint presence in RemoveExplicitReturnType

  Show description for 8335c0b
  SebastianAtWork

  committed
  8335c0b

  Copy full SHA for 8335c0b

• * feat(FSharp.Editor.Tests): add new test cases for AddExplicitReturnType and RemoveExplicitReturnType

  Show description for 0918cfb
  SebastianAtWork

  committed
  0918cfb

  Copy full SHA for 0918cfb

• * feat(FSharp.Editor.Tests): add AsyncBugReproduction.fs to test suite

  Show description for 0a8c952
  SebastianAtWork

  committed
  0a8c952

  Copy full SHA for 0a8c952

• bug: boiled bug down more

  SebastianAtWork

  committed
  ac3cb24

  Copy full SHA for ac3cb24

• * feat(FSharpParseFileResults.fs): add RangeOfReturnTypeDefinition method

  Show description for 168dc63
  SebastianAtWork

  committed
  168dc63

  Copy full SHA for 168dc63

• * refactor(FSharp.Editor.Tests): remove async tasks from test cases and simplify code

  Show description for 5978ad5
  SebastianAtWork

  committed
  5978ad5

  Copy full SHA for 5978ad5

• * refactor(FSharp.Editor): simplify refactoring process in AddExplicitReturnType.fs and RefactorTestFramework.fs

  Show description for c6ea3fc
  SebastianAtWork

  committed
  c6ea3fc

  Copy full SHA for c6ea3fc

• remove RemoveExplicitReturnType and save for a different PR

  SebastianAtWork

  committed
  a135896

  Copy full SHA for a135896

• test: fixed test formatting

  SebastianAtWork

  committed
  e4f849c

  Copy full SHA for e4f849c

• * refactor(FSharp.Editor): remove InternalOptionBuilder.fs and update dependent files

  SebastianAtWork

  committed
  99e3686

  Copy full SHA for 99e3686

• * refactor(FSharp.Editor.Tests): rename AddExplicitReturnType.fs to AddExplicitReturnTypeTests.fs

  SebastianAtWork

  committed
  7274f3e

  Copy full SHA for 7274f3e

• * refactor(FSharp.Editor): remove unused imports in AddExplicitReturnType.fs, AddExplicitReturnTypeTests.fs and RefactorTestFramework.fs

  SebastianAtWork

  committed
  ec5ab97

  Copy full SHA for ec5ab97

• * refactor(FSharpParseFileResults.fs, FSharpParseFileResults.fsi, RefactorTestFramework.fs): remove unused RangeOfReturnTypeDefinition method

  SebastianAtWork

  committed
  30b5fe7

  Copy full SHA for 30b5fe7

• * feat(FSharp.Editor.Tests): add GetLastDocument method in RoslynHelpers.fs

  Show description for a3d2ce2
  SebastianAtWork

  committed
  a3d2ce2

  Copy full SHA for a3d2ce2

• * refactor(RefactorTestFramework.fs): simplify TestContext type and remove unused TestCodeFix type

  SebastianAtWork

  committed
  f8bfd0c

  Copy full SHA for f8bfd0c

• * style: add space after colon in type annotations in AddExplicitReturnType.fs and AddExplicitReturnTypeTests.fs

  SebastianAtWork

  committed
  3a2257f

  Copy full SHA for 3a2257f

• * refactor(AddExplicitReturnType.fs): remove unused CancellationToken and reformat code

  Show description for 1d24e5a
  SebastianAtWork

  committed
  1d24e5a

  Copy full SHA for 1d24e5a

• * feat(FSharp.Editor): add checks for function or value names in AddExplicitReturnType

  Show description for c700bf8
  SebastianAtWork

  committed
  c700bf8

  Copy full SHA for c700bf8

• * refactor(AddExplicitReturnTypeTests.fs): remove unused System.Linq import

  SebastianAtWork

  committed
  9bb4545

  Copy full SHA for 9bb4545

• * refactor(RefactorTestFramework.fs): remove unused import Microsoft.VisualStudio.FSharp.Editor

  SebastianAtWork

  committed
  867803d

  Copy full SHA for 867803d

• I dont know this file type

  SebastianAtWork

  committed
  77987ca

  Copy full SHA for 77987ca

• * refactor(AddExplicitReturnType.fs): simplify match expressions and refactor refactor function parameters

  SebastianAtWork

  committed
  2a6e573

  Copy full SHA for 2a6e573

• fixed: AddExplicitReturnTypeTests

  Show description for 5d004eb
  SebastianAtWork

  committed
  5d004eb

  Copy full SHA for 5d004eb

• Automated command ran: fantomas

  Show description for 3edc9d0
  github-actions[bot]

  committed
  3edc9d0

  Copy full SHA for 3edc9d0

• Merge branch 'dotnet:main' into features/codefix-return-type

  SebastianAtWork

  authored
  555ff74

  Copy full SHA for 555ff74

Commits on Dec 2, 2023

• * fix: add space before equals sign in type annotations in AddExplicitReturnType.fs and AddExplicitReturnTypeTests.fs

  SebastianAtWork

  committed
  e59af47

  Copy full SHA for e59af47

• * feat(AddExplicitReturnType.fs): add support for generic return types and handle empty inferred types

  Show description for 4c48771
  SebastianAtWork

  committed
  4c48771

  Copy full SHA for 4c48771

• * refactor(AddExplicitReturnType.fs): improve inferredType calculation and refactor method signature

  Show description for 79603fb
  SebastianAtWork

  committed
  79603fb

  Copy full SHA for 79603fb

• fix: remove strange artifact

  SebastianAtWork

  committed
  d0940c2

  Copy full SHA for d0940c2

• * refactor(FSharp.Editor): rename 'AddExplicitReturnTypeAnnotation' to 'AddReturnTypeAnnotation' in all language files

  SebastianAtWork

  committed
  81623d5

  Copy full SHA for 81623d5

• * refactor(FSharp.Editor): simplify CancellationToken usage in TestContext

  Show description for ca88258
  SebastianAtWork

  committed
  ca88258

  Copy full SHA for ca88258

Commits on Dec 6, 2023

• Merge branch 'dotnet:main' into features/codefix-return-type

  SebastianAtWork

  authored
  2590310

  Copy full SHA for 2590310

• refactor: Improve code readability and performance

  Show description for 7283db8
  SebastianAtWork

  committed
  7283db8

  Copy full SHA for 7283db8

• refactor: Improve code readability and performance

  Show description for 0a5a193
  SebastianAtWork

  committed
  0a5a193

  Copy full SHA for 0a5a193

Commits on Dec 13, 2023

• Merge branch 'dotnet:main' into features/codefix-return-type

  SebastianAtWork

  authored
  e7d8114

  Copy full SHA for e7d8114

• refactor: Refactored AddExplicitReturnType.fs and AddExplicitReturnTypeTests.fs

  Show description for d9310a3
  SebastianAtWork

  committed
  d9310a3

  Copy full SHA for d9310a3

Commits on Dec 15, 2023

• Merge branch 'dotnet:main' into features/codefix-return-type

  SebastianAtWork

  authored
  e51805d

  Copy full SHA for e51805d

• refactor: Simplify AddExplicitReturnType logic

  Show description for 696b930
  SebastianAtWork

  committed
  696b930

  Copy full SHA for 696b930

• refactor: Add explicit return type to sum function

  Show description for 323c863
  SebastianAtWork

  committed
  323c863

  Copy full SHA for 323c863

• tests: Added new special test cases for already existing opens

  SebastianAtWork

  committed
  6fb62df

  Copy full SHA for 6fb62df

Commits on Dec 16, 2023

• refactor: Update return type annotation in localization files

  Show description for 8cf85ec
  SebastianAtWork

  committed
  8cf85ec

  Copy full SHA for 8cf85ec

• refactor: Rename AddExplicitReturnType to AddReturnType

  Show description for 3a7eac4
  SebastianAtWork

  committed
  3a7eac4

  Copy full SHA for 3a7eac4

• Merge branch 'dotnet:main' into features/codefix-return-type

  SebastianAtWork

  authored
  b4ea8b9

  Copy full SHA for b4ea8b9

Commits on Dec 19, 2023

• Merge branch 'main' into features/codefix-return-type

  SebastianAtWork

  authored
  14c2acc

  Copy full SHA for 14c2acc