Fix #13197 #13870
Merged
Fix #13197 #13870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyme
changed the title
|
This is ready |
KevinRansom
approved these changes
Sep 12, 2022
There was a problem hiding this comment.
Thanks for this.
I chatted with @dsyme and we agreed that, in the longer term we need to use type the type-forwards and similar metadata to establish type identity rather than hard coded equivalence based on type + Assembly Identity. However, this solution solves the immediate issue and it is an issue we expect to see others encounter without this fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression #13197 related to multiemit (actually, it's related to the use of the ILWrite binary writer rather then Reflection.Emit).
The problem here is that when
/usesdkrefs-is used, the "actual" primary assembly of the compilation is System.Private.CoreLib - i.e. that's where System.Object is defined. However the "target" primary assembly we use remains System.Runtime - that is that's what we code generate for.To emit correct code we need to detect that
System.Private.CoreLibis an equivalent primary assembly reference.