Format src/Compiler/Driver #13195
Merged
Format src/Compiler/Driver #13195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyme
commented
May 25, 2022
dsyme
commented
May 25, 2022
dsyme
force-pushed
the
ft36
branch
2 times, most recently
from
b22186b to
7d83f71
Compare
dsyme
force-pushed
the
ft36
branch
2 times, most recently
from
2a23431 to
1fe1e37
Compare
|
@vzarytovskii This is ready for review. I've been through every file and there were some quite intrusive formatting changes. Because of this I've made a set of pre-formatting changes to make code better (e.g. avoiding large indentations) and thus give decent code after formatting. The pre-formatting changes are all except the last "apply formatting" commit, and should really be reviewed separately to the automatic code formatting itself. However there are no controversial changes in the pre-formatting, just cleanup. |
vzarytovskii
approved these changes
May 30, 2022
dsyme
changed the title
KevinRansom
pushed a commit
that referenced
this pull request
May 31, 2022
* update fantomas (#13206) * Format most of FSharp.Core (#13150) * modify fantomasignore * fix setting * no single line functions in FSHarp.Core * update fantomas * apply formatting * Format src/Compiler/Driver (#13195) * adjust settings * adjust code * adjust settings * adjust code * fix code before formatting * remove unnecessary yield * manual pre-formatting * preadjust code * preadjust code * preadjust code * preadjust code * adjust settings" * adjust settings" * adjust settings * adjust settings * fix build * adjust settings * adjust code * adjust code * adjust code * update fantomas * apply formatting * apply formatting (fix build) (#13209) * preformat * apply formatting Co-authored-by: Don Syme <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fsharp_max_if_then_else_short_widthto be larger (40 --> 60) across all codeWhen reviewing this, there effectively two parts