Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experiment] FSharpProject snapshot #11775

Closed
wants to merge 20 commits into from
Closed

Conversation

TIHan
Copy link
Contributor

@TIHan TIHan commented Jul 2, 2021

This is currently an experiment.

  • Adds a new type: FSharpProject
    • The type represents a F# project for use in an IDE/editor and is internally implemented by an incremental builder which contains the state; the state is immutable.
    • The type can be instantiated separately from FSharpChecker.
    • Because the internal state is immutable, any logical update that needs to be done to the project will result in the creation of a new FSharpProject instance; effectively making it a snapshot.
    • This is useful for few reasons:
      • Synchronizing IDE/editor's view of a project with FSharpProject becomes easier to manage as the IDE/editor is in charge of maintaining the state rather than FCS; this is hugely important.
      • Making an update to a FSharpProject will not impact other FSharpProject instances.
      • Being able to reason about the state of a FSharpProject is easier.
    • Open Questions
      • How is type provider invalidation going to be handled? Type providers can inherently be mutable, making the FSharpProject technically not immutable if it references a type provider.
      • Do we have any APIs that rely on forward looking ahead of files in a project?

Acceptance Criteria

  • Move out of 'Experimental' mode
  • Review API Design
  • Integrate into VS
  • Tests

@TIHan
Copy link
Contributor Author

TIHan commented Oct 26, 2021

This was an experiment to see what the work looks like when we introduce FSharpProject. We are first going to introduce the FSharpSource type (see #12305) before we think about how to create a FSharpProject type.

@TIHan TIHan closed this Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant