Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build warnings #1124

Merged
merged 3 commits into from
Apr 28, 2016
Merged

Conversation

enricosada
Copy link
Contributor

@enricosada enricosada commented Apr 27, 2016

  • Microsoft.Build version 14.0.0.0.0 not found
03:51:50      3>C:\Program Files (x86)\MSBuild\14.0\bin\Microsoft.Common.CurrentVersion.targets(1819,5): warning MSB3106: Assembly strong name "Microsoft.Build, Version=14.0.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" is either a path which could not be found or it is a full assembly name which is badly formed. If it is a full assembly name it may contain characters that need to be escaped with backslash(\). Those characters are Equals(=), Comma(,), Quote("), Apostrophe('), Backslash(\). [D:\j\workspace\release_ci_pa---3f142ccc\src\fsharp\FSharp.Compiler-proto\FSharp.Compiler-proto.fsproj]
  • Microsoft.DiaSymReader.PortablePdb not found
3>C:\Program Files (x86)\MSBuild\14.0\bin\Microsoft.Common.CurrentVersion.targets(1820,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "Microsoft.DiaSymReader.PortablePdb". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors. [C:\projects\visualfsharp-radou\src\fsharp\FSharp.Compiler-proto\FSharp.Compiler-proto.fsproj]
  • wrong Microsoft.NETCore.Runtime.CoreCLR, rc3 instead of rc2
04:08:02   OK https://www.nuget.org/api/v2/FindPackagesById()?id='Microsoft.NETCore.Windows.ApiSets' 85ms
04:08:02 WARNING: Dependency specified was Microsoft.NETCore.Runtime.CoreCLR (>= 1.0.1-rc2-23911) but ended up with Microsoft.NETCore.Runtime.CoreCLR 1.0.1-rc3-23720.

the Microsoft.NETCore.Runtime.CoreCLR version used in tests/fsharp was different than the one used in lkg ( 1.0.1 doesnt have rc2 ), i used the one in lkg (is correct)

@enricosada enricosada force-pushed the fix_build_msbuild_version branch from 2405784 to 9c9d171 Compare April 27, 2016 09:48
@enricosada enricosada changed the title [WIP] fix build [WIP] fix build warnings Apr 27, 2016
@enricosada enricosada changed the title [WIP] fix build warnings fix build warnings Apr 27, 2016
@enricosada
Copy link
Contributor Author

ok, ready for review @KevinRansom

@forki
Copy link
Contributor

forki commented Apr 27, 2016

/cc @isaacabraham

@dsyme
Copy link
Contributor

dsyme commented Apr 28, 2016

I'll merge this - @KevinRansom please review and/or revert if necessary,

@dsyme dsyme merged commit 5d6ed04 into dotnet:master Apr 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants