Add range of do keyword to SynExpr.Do. #10853
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
force-pushed
the
do-keyword-range
branch
from
dcde857 to
b01a812
Compare
baronfel
reviewed
Jan 8, 2021
| @@ -695,6 +695,7 @@ type SynExpr = | |||
| /// F# syntax: do expr | |||
| | Do of | |||
| expr: SynExpr * | |||
There was a problem hiding this comment.
this makes me wish that we could include parameter-level documentation on DU members specifically and have them rolled-up somehow.
|
This looks sane to me. I'm loving how your experiences in Fantomas flow back here in terms of enhancements and improvements to the AST structures! |
|
I've assumed I've previously proposed this fix: #10365, so it'd be possible to calculate |
|
@auduchinok, please consider the following example: let a =
// Import new etags of pushed items
do
pushed
|> Option.bind Dto.changesAsImport
|> Option.iter (fun changes -> update (Import changes) |> ignore)matching AST: ImplFile
(ParsedImplFileInput
("tmp.fsx", true, QualifiedNameOfFile Tmp$fsx, [], [],
[SynModuleOrNamespace
([Tmp], false, AnonModule,
[Let
(false,
[Binding
(None, NormalBinding, false, false, [],
PreXmlDoc ((1,4), FSharp.Compiler.XmlDoc+XmlDocCollector),
SynValData
(None, SynValInfo ([], SynArgInfo ([], false, None)), None),
Named
(Wild tmp.fsx (1,4--1,5) IsSynthetic=false, a, false, None,
tmp.fsx (1,4--1,5) IsSynthetic=false), None,
Do
(App
(NonAtomic, false,
App
(NonAtomic, true, Ident op_PipeRight,
App
(NonAtomic, false,
App
(NonAtomic, true, Ident op_PipeRight,
Ident pushed,
tmp.fsx (4,8--5,10) IsSynthetic=false),
App
(NonAtomic, false,
LongIdent
(false,
LongIdentWithDots
([Option; bind],
[tmp.fsx (5,17--5,18) IsSynthetic=false]),
None, tmp.fsx (5,11--5,22) IsSynthetic=false),
LongIdent
(false,
LongIdentWithDots
([Dto; changesAsImport],
[tmp.fsx (5,26--5,27) IsSynthetic=false]),
None, tmp.fsx (5,23--5,42) IsSynthetic=false),
tmp.fsx (5,11--5,42) IsSynthetic=false),
tmp.fsx (4,8--5,42) IsSynthetic=false),
tmp.fsx (4,8--6,10) IsSynthetic=false),
App
(NonAtomic, false,
LongIdent
(false,
LongIdentWithDots
([Option; iter],
[tmp.fsx (6,17--6,18) IsSynthetic=false]), None,
tmp.fsx (6,11--6,22) IsSynthetic=false),
Paren
(Lambda
(false, false,
SimplePats
([Id
(changes, None, false, false, false,
tmp.fsx (6,28--6,35) IsSynthetic=false)],
tmp.fsx (6,28--6,35) IsSynthetic=false),
App
(NonAtomic, false,
App
(NonAtomic, true, Ident op_PipeRight,
App
(NonAtomic, false, Ident update,
Paren
(App
(NonAtomic, false, Ident Import,
Ident changes,
tmp.fsx (6,47--6,61) IsSynthetic=false),
tmp.fsx (6,46--6,47) IsSynthetic=false,
Some
tmp.fsx (6,61--6,62) IsSynthetic=false,
tmp.fsx (6,46--6,62) IsSynthetic=false),
tmp.fsx (6,39--6,62) IsSynthetic=false),
tmp.fsx (6,39--6,65) IsSynthetic=false),
Ident ignore,
tmp.fsx (6,39--6,72) IsSynthetic=false),
Some
([Named
(Wild
tmp.fsx (6,28--6,35) IsSynthetic=false,
changes, false, None,
tmp.fsx (6,28--6,35) IsSynthetic=false)],
App
(NonAtomic, false,
App
(NonAtomic, true, Ident op_PipeRight,
App
(NonAtomic, false, Ident update,
Paren
(App
(NonAtomic, false,
Ident Import, Ident changes,
tmp.fsx (6,47--6,61) IsSynthetic=false),
tmp.fsx (6,46--6,47) IsSynthetic=false,
Some
tmp.fsx (6,61--6,62) IsSynthetic=false,
tmp.fsx (6,46--6,62) IsSynthetic=false),
tmp.fsx (6,39--6,62) IsSynthetic=false),
tmp.fsx (6,39--6,65) IsSynthetic=false),
Ident ignore,
tmp.fsx (6,39--6,72) IsSynthetic=false)),
tmp.fsx (6,24--6,72) IsSynthetic=false),
tmp.fsx (6,23--6,24) IsSynthetic=false,
Some tmp.fsx (6,72--6,73) IsSynthetic=false,
tmp.fsx (6,23--6,73) IsSynthetic=false),
tmp.fsx (6,11--6,73) IsSynthetic=false),
tmp.fsx (4,8--6,73) IsSynthetic=false),
tmp.fsx (4,8--6,73) IsSynthetic=false),
tmp.fsx (1,4--1,5) IsSynthetic=false,
DebugPointAtBinding tmp.fsx (1,0--6,73) IsSynthetic=false)],
tmp.fsx (1,0--6,73) IsSynthetic=false)], PreXmlDocEmpty, [], None,
tmp.fsx (1,0--7,0) IsSynthetic=false)], (true, true)))The range of |
|
@nojaf Thanks for the example. If the |
|
Hi @auduchinok. let a =
do
foobar
do!
foobarBangAST ImplFile
(ParsedImplFileInput
("tmp.fsx", true, QualifiedNameOfFile Tmp$fsx, [], [],
[SynModuleOrNamespace
([Tmp], false, AnonModule,
[Let
(false,
[Binding
(None, NormalBinding, false, false, [],
PreXmlDoc ((1,4), FSharp.Compiler.XmlDoc+XmlDocCollector),
SynValData
(None, SynValInfo ([], SynArgInfo ([], false, None)), None),
Named
(Wild tmp.fsx (1,4--1,5) IsSynthetic=false, a, false, None,
tmp.fsx (1,4--1,5) IsSynthetic=false), None,
Sequential
(Both, true,
Do (Ident foobar, tmp.fsx (3,8--3,14) IsSynthetic=false),
DoBang
(Ident foobarBang, tmp.fsx (4,4--5,18) IsSynthetic=false),
tmp.fsx (3,8--5,18) IsSynthetic=false),
tmp.fsx (1,4--1,5) IsSynthetic=false, NoDebugPointAtLetBinding)],
tmp.fsx (1,0--5,18) IsSynthetic=false)], PreXmlDocEmpty, [], None,
tmp.fsx (1,0--5,18) IsSynthetic=false)], (true, true)))DoBang starts at the keyword, while Do does not. |
|
Closing in favor of #10881 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #10198.
A different keyword than mentioned in the issue but the concept still stands.
Having this information would be useful to solve fsprojects/fantomas#1343.
Let me know what you think @cartermp.