Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename AIFunctionFactoryOptions and make all properties nullable. #5906

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Rename AIFunctionFactoryOptions and make all properties nullable. #5906

merged 1 commit into from
Feb 14, 2025

Conversation

eiriktsarpalis
Copy link
Member

@eiriktsarpalis eiriktsarpalis commented Feb 14, 2025 •
edited by dotnet-policy-service bot
Loading

Salvages the API changes from #5905

Microsoft Reviewers: Open in CodeFlow

@eiriktsarpalis eiriktsarpalis requested a review from a team as a code owner February 14, 2025 13:09
@eiriktsarpalis eiriktsarpalis changed the title Renamed AIFunctionFactoryOptions and make all properties nullable. Rename AIFunctionFactoryOptions and make all properties nullable. Feb 14, 2025
@eiriktsarpalis eiriktsarpalis enabled auto-merge (squash) February 14, 2025 13:40
@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.AI.Ollama Line 80 78.2 🔻
Microsoft.Extensions.AI.Evaluation.Quality Line 88 7.57 🔻
Microsoft.Extensions.AI.Evaluation.Quality Branch 88 16.42 🔻
Microsoft.Extensions.AI.Evaluation.Console Line 88 8.26 🔻
Microsoft.Extensions.AI.Evaluation.Console Branch 88 17.07 🔻
Microsoft.Extensions.Caching.Hybrid Line 86 82.92 🔻
Microsoft.Extensions.AI.Evaluation.Reporting Line 88 72.06 🔻
Microsoft.Extensions.AI.Evaluation.Reporting Branch 88 64.8 🔻
Microsoft.Extensions.AI.Evaluation Line 88 58.67 🔻
Microsoft.Extensions.AI.Evaluation Branch 88 56.67 🔻
Microsoft.Gen.MetadataExtractor Line 98 57.35 🔻
Microsoft.Gen.MetadataExtractor Branch 98 62.5 🔻
Microsoft.Extensions.AI.OpenAI Line 77 68.04 🔻
Microsoft.Extensions.AI.OpenAI Branch 77 49.8 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI.AzureAIInference 91 92
Microsoft.Extensions.AI 88 89

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=952548&view=codecoverage-tab

@eiriktsarpalis eiriktsarpalis merged commit f225a93 into dotnet:main Feb 14, 2025
6 checks passed
@eiriktsarpalis eiriktsarpalis deleted the schemacreateoptions branch February 14, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees

@eiriktsarpalis eiriktsarpalis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eiriktsarpalis @dotnet-comment-bot @stephentoub