Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable API compat validation #5871

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Enable API compat validation #5871

merged 1 commit into from
Feb 12, 2025

Conversation

RussKie
Copy link
Member

@RussKie RussKie commented Feb 11, 2025 •
edited by dotnet-policy-service bot
Loading

Microsoft Reviewers: Open in CodeFlow

@RussKie RussKie force-pushed the apivalidation branch 2 times, most recently from beda5f1 to d3c7d3a Compare February 11, 2025 04:55
@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.AI.OpenAI Line 77 71.71 🔻
Microsoft.Extensions.AI.OpenAI Branch 77 53.28 🔻
Microsoft.Extensions.Caching.Hybrid Line 86 82.92 🔻
Microsoft.Extensions.AI.Ollama Line 80 78.2 🔻
Microsoft.Gen.MetadataExtractor Line 98 57.35 🔻
Microsoft.Gen.MetadataExtractor Branch 98 62.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI.AzureAIInference 91 92
Microsoft.Extensions.AI.Abstractions 83 85
Microsoft.Extensions.AI 88 89

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=947663&view=codecoverage-tab

@RussKie RussKie marked this pull request as ready for review February 11, 2025 23:14
@RussKie RussKie requested review from a team as code owners February 11, 2025 23:14
@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.AI.OpenAI Line 77 68.75 🔻
Microsoft.Extensions.AI.OpenAI Branch 77 50.41 🔻
Microsoft.Extensions.AI.Ollama Line 80 78.2 🔻
Microsoft.Gen.MetadataExtractor Line 98 57.35 🔻
Microsoft.Gen.MetadataExtractor Branch 98 62.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI.Abstractions 83 85
Microsoft.Extensions.Caching.Hybrid 86 87
Microsoft.Extensions.AI 88 89
Microsoft.Extensions.AI.AzureAIInference 91 92

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=948992&view=codecoverage-tab

wtgodbe
wtgodbe approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me

@RussKie RussKie enabled auto-merge (squash) February 12, 2025 00:41
@RussKie RussKie merged commit 698296d into dotnet:main Feb 12, 2025
6 checks passed
@RussKie RussKie deleted the apivalidation branch February 12, 2025 02:49
RussKie
RussKie commented Feb 12, 2025
View reviewed changes
src/Libraries/Microsoft.Extensions.AI.Abstractions/Microsoft.Extensions.AI.Abstractions.csproj
@@ -9,6 +9,7 @@
<PropertyGroup>
<Stage>preview</Stage>
<SuppressFinalPackageVersion>true</SuppressFinalPackageVersion>
<EnablePackageValidation>false</EnablePackageValidation>
Copy link
Member Author

@RussKie RussKie Feb 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shyamnamboodiripad FYI, you may need to apply the same to the Eval projects under /src/Libraries.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks for the heads up! That probably explains why recent builds in #5873 have been failing...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I have cycles, I'll look into generalising MSBuild configs that are required for each AI project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyamnamboodiripad shyamnamboodiripad shyamnamboodiripad left review comments

@sebastienros sebastienros sebastienros approved these changes

@stephentoub stephentoub stephentoub approved these changes

@wtgodbe wtgodbe wtgodbe approved these changes

Assignees

@RussKie RussKie

Labels
area-infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RussKie @dotnet-comment-bot @sebastienros @stephentoub @shyamnamboodiripad @wtgodbe