Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw when getting context info for a bad connection #19375

Merged
merged 1 commit into from
Dec 23, 2019

Conversation

ajcvickers
Copy link
Contributor

Fixes #9244

@bricelam
Copy link
Contributor

I seem to remember other commands throwing too:

  • migrations add
  • migrations list
  • migrations remove --force
  • migrations script

@ajcvickers
Copy link
Contributor Author

@bricelam Do you remember any more specifics? I see these operations creating the context instance, but this should be fine. They don't seem to get the DbConnection directly. Are there any customer-reported issues I could look at?

@ajcvickers ajcvickers merged commit ecd80d6 into master Dec 23, 2019
@ajcvickers ajcvickers deleted the ButSomehowTheVitalConnectionIsMade1220 branch December 23, 2019 20:41
@bricelam
Copy link
Contributor

Don’t remember. It was a long tome ago, it may have gotten fixed by some other refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dotnet ef dbcontext info tries to create the connection
2 participants