#5783 - Casting with as causing exceptions #19269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
approved these changes
Dec 13, 2019
|
Need to convert tests to AssertQuery syntax before merge. |
smitpatel
reviewed
Dec 14, 2019
| { | ||
| using var context = CreateContext(); | ||
|
|
||
| var query = context.LevelOne.Include(l1 => l1.OneToMany_Optional1) |
There was a problem hiding this comment.
Include is not required here.
smitpatel
force-pushed
the
fix_5783_wip
branch
from
64e7a5f to
4e798eb
Compare
smitpatel
force-pushed
the
fix_5783_wip
branch
from
4e798eb to
6b5fae5
Compare
|
@svengeance - Thank you for contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor code change to fix translation of
x.Foo as Bar.There were 2 different exceptions here - either KeyNotFound when the as was inside an aggregate like Sum, or a ClientEvaluation when the as as inside a a Where clause. With tests covering both of these, the 3'rd test covers the exact repro that was reported in issue #5783