Further improvements on null protection/propagation #17513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
Aug 30, 2019
src/EFCore.InMemory/Query/Internal/InMemoryProjectionBindingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
|
What issue does this fix? There are no tests enabled for in-memory. |
maumar
force-pushed
the
more_null_protection
branch
2 times, most recently
from
6a217ea to
7113448
Compare
|
it fixes issue described in #16575. I enabled a few tests in the new version of the pr |
maumar
force-pushed
the
more_null_protection
branch
from
7113448 to
ac25be0
Compare
smitpatel
reviewed
Aug 30, 2019
src/EFCore.InMemory/Query/Internal/InMemoryProjectionBindingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
Fixed cases involving member pushdown. We now remove all converts from nullable to non-nullable (even ones explicitly added by users) so that nullability can propagate to the very top.
maumar
force-pushed
the
more_null_protection
branch
from
ac25be0 to
a248890
Compare
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed cases involving member pushdown. We now remove all converts from nullable to non-nullable (even ones explicitly added by users) so that nullability can propagate to the very top.