Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Microsoft.Data.Sqlite.Core TFMs #34771

Closed
AndriySvyryd opened this issue Sep 26, 2024 · 4 comments · Fixed by #35589
Closed

Update Microsoft.Data.Sqlite.Core TFMs #34771

AndriySvyryd opened this issue Sep 26, 2024 · 4 comments · Fixed by #35589
Labels
area-adonet-sqlite closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. preview-2 type-enhancement
Milestone
10.0.0

Comments

@AndriySvyryd
Copy link
Member

For EF 10 it should target net10.0;netstandard2.0
@AndriySvyryd AndriySvyryd added this to the 10.0.0 milestone Sep 26, 2024
@AndriySvyryd AndriySvyryd self-assigned this Sep 26, 2024
@AndriySvyryd AndriySvyryd mentioned this issue Sep 26, 2024
Merged
AndriySvyryd added a commit that referenced this issue Feb 5, 2025
@AndriySvyryd
Update Microsoft.Data.Sqlite.Core TFMs
20701d2 
Fixes #34771
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Feb 5, 2025
@AndriySvyryd AndriySvyryd removed their assignment Feb 5, 2025
@AndriySvyryd AndriySvyryd mentioned this issue Feb 5, 2025
Merged
@Varorbc
Copy link
Contributor

Varorbc commented Feb 5, 2025

Are there any plans to drop netstandard2.0?

@AndriySvyryd
Copy link
Member Author

@Varorbc Not currently

@Varorbc
Copy link
Contributor

Varorbc commented Feb 6, 2025

@AndriySvyryd
Since other libraries like pgsql and SqlClient have already dropped support for netstandard2.0, should we also consider removing it starting with EF10?

@AndriySvyryd
Copy link
Member Author

As long as SQLitePCLRaw.core targets netstandard2.0 I don't see much benefit for the users from us dropping it as we'd still need to multi-target for net472

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-adonet-sqlite closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. preview-2 type-enhancement
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

Update Microsoft.Data.Sqlite.Core TFMs dotnet/efcore
3 participants
@maumar @Varorbc @AndriySvyryd