Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ef.exe TFMs #34654

Closed
AndriySvyryd opened this issue Sep 11, 2024 · 4 comments · Fixed by #35488
Closed

Update ef.exe TFMs #34654

AndriySvyryd opened this issue Sep 11, 2024 · 4 comments · Fixed by #35488
Labels
area-tools closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. preview-1 type-enhancement
Milestone

Comments

@AndriySvyryd
Copy link
Member

For EF 10 it should target net10.0;net472

@ViktorHofer
Copy link
Member

ViktorHofer commented Jan 8, 2025

Alternatively, you could target $(NetMinimum) (which is an Arcade defined property that maps to the minimum supported .NETCoreApp version) which currently is net8.0: https://github.com/dotnet/arcade/blob/e7cb34898a1b610eb2a22591a2178da6f1fb7e3c/src/Microsoft.DotNet.Arcade.Sdk/tools/TargetFrameworkDefaults.props#L21

By doing that and setting a roll forward policy (RollForward=Major), the tool can be used on all supported .NETCoreApp runtimes, not just with a .NET 10 runtime installed.

@AndriySvyryd
Copy link
Member Author

@ViktorHofer We decided to target $(DefaultNetCoreTargetFramework) as we don't have a strong signal that compatibility with older SDKs is needed and we want to depend on the latest Microsoft.CodeAnalysis.* to avoid conflicting transitive dependencies - #34637

@ViktorHofer
Copy link
Member

You should be able to target the latest CodeAnalysis packages when targeting and older .NETCoreApp TFM like net8.0. Or am I missing something here?

@AndriySvyryd
Copy link
Member Author

Even if they allow to target an older TFM they still require the current VS/SDK to be installed to actually work, so there's little real benefit for targeting older TFMs and it confuses users when the versioning between the TFM, SDK, Runtime and EF doesn't match

AndriySvyryd added a commit that referenced this issue Jan 16, 2025
AndriySvyryd added a commit that referenced this issue Jan 17, 2025
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jan 17, 2025
@AndriySvyryd AndriySvyryd removed their assignment Jan 17, 2025
AndriySvyryd added a commit that referenced this issue Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-tools closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. preview-1 type-enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants