Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement an IDbContextFactory that pools context instances #21247

Closed
ajcvickers opened this issue Jun 12, 2020 · 0 comments · Fixed by #21431
Closed

Implement an IDbContextFactory that pools context instances #21247

ajcvickers opened this issue Jun 12, 2020 · 0 comments · Fixed by #21431
Labels
area-dbcontext closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
5.0.0

Comments

@ajcvickers
Copy link
Contributor

ajcvickers commented Jun 12, 2020 •
edited
Loading

This is a further extension of #18575 implemented in #21246.

It should not be too hard to hook a factory into the existing pooling implementation.
ajcvickers added a commit that referenced this issue Jun 13, 2020
@ajcvickers
Allow DbContextFactory to use a pool
599f444 
Fixes #21247

Uses the existing pooling code, although some divergence here could result in better perf, which could be relevant for high-throughput cases like SingleQuery.

Has the same restrictions as regular pooling since the context instances are reused.
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 13, 2020
@ajcvickers ajcvickers self-assigned this Jun 13, 2020
@ajcvickers ajcvickers added this to the 5.0.0 milestone Jun 13, 2020
ajcvickers added a commit that referenced this issue Jun 13, 2020
@ajcvickers
Allow DbContextFactory to use a pool
558499d 
Fixes #21247

Uses the existing pooling code, although some divergence here could result in better perf, which could be relevant for high-throughput cases like SingleQuery.

Has the same restrictions as regular pooling since the context instances are reused.
@ajcvickers ajcvickers mentioned this issue Jun 13, 2020
Closed
ajcvickers added a commit that referenced this issue Jun 14, 2020
@ajcvickers
Allow DbContextFactory to use a pool
14643a8 
Fixes #21247

Uses the existing pooling code, although some divergence here could result in better perf, which could be relevant for high-throughput cases like SingleQuery.

Has the same restrictions as regular pooling since the context instances are reused.
ajcvickers added a commit that referenced this issue Jun 14, 2020
@ajcvickers
Allow DbContextFactory to use a pool
4fa6721 
Fixes #21247

Uses the existing pooling code, although some divergence here could result in better perf, which could be relevant for high-throughput cases like SingleQuery.

Has the same restrictions as regular pooling since the context instances are reused.
ajcvickers added a commit that referenced this issue Jun 15, 2020
@ajcvickers
Allow DbContextFactory to use a pool
19046fa 
Fixes #21247

Uses the existing pooling code, although some divergence here could result in better perf, which could be relevant for high-throughput cases like SingleQuery.

Has the same restrictions as regular pooling since the context instances are reused.
ajcvickers added a commit that referenced this issue Jun 15, 2020
@ajcvickers
Allow DbContextFactory to use a pool
e050edb 
Fixes #21247

Uses the existing pooling code, although some divergence here could result in better perf, which could be relevant for high-throughput cases like SingleQuery.

Has the same restrictions as regular pooling since the context instances are reused.
ajcvickers added a commit that referenced this issue Jun 27, 2020
@ajcvickers
Allow DbContextFactory to use a pool
ea10927 
Fixes #21247

Uses the existing pooling code, although some divergence here could result in better perf, which could be relevant for high-throughput cases like SingleQuery.

Has the same restrictions as regular pooling since the context instances are reused.
ajcvickers added a commit that referenced this issue Jun 27, 2020
@ajcvickers
Allow DbContextFactory to use a pool
3a9070b 
Fixes #21247

Refactors the context pooling code to create a cleaner responsibility of services.

Has the same restrictions as regular pooling since the context instances are reused.
@ajcvickers ajcvickers mentioned this issue Jun 27, 2020
Merged
ajcvickers added a commit that referenced this issue Jun 28, 2020
@ajcvickers
Allow DbContextFactory to use a pool
1dafcf0 
Fixes #21247

Refactors the context pooling code to create a cleaner responsibility of services.

Has the same restrictions as regular pooling since the context instances are reused.
ajcvickers added a commit that referenced this issue Jun 28, 2020
@ajcvickers
Allow DbContextFactory to use a pool
d7b9414 
Fixes #21247

Refactors the context pooling code to create a cleaner responsibility of services.

Has the same restrictions as regular pooling since the context instances are reused.
ajcvickers added a commit that referenced this issue Jun 28, 2020
@ajcvickers
Allow DbContextFactory to use a pool (#21431)
af10d48 
Fixes #21247

Refactors the context pooling code to create a cleaner responsibility of services.

Has the same restrictions as regular pooling since the context instances are reused.
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview8 Jul 14, 2020
@ajcvickers ajcvickers mentioned this issue Aug 27, 2020
Closed
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview8, 5.0.0 Nov 7, 2020
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-dbcontext closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
5.0.0
1 participant
@ajcvickers