-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Where bool column needs to convert to equality when value converter is applied #18147
Comments
Also errors on Cosmos. |
Work-around: Compare to true explicitly. var query = context.Set<Blog>().Where(b => b.IsVisible == true).ToList(); |
Also errors on PostgreSQL :( |
Same goes for Pomelo.EntityFrameworkCore.MySql |
…alue converter is applied Fix is to detect bool columns with value converters (upon initial translation) and apply comparison with constant true (with the same mapping). Also, we need to recognize this pattern during SqlExpression optimization, so that it' doesn't get simplified from 'a == true' to 'a'
…alue converter is applied Fix is to detect bool columns with value converters (upon initial translation) and apply comparison with constant true (with the same mapping). Also, we need to recognize this pattern during SqlExpression optimization, so that it' doesn't get simplified from 'a == true' to 'a' Resolves #18147
…alue converter is applied Fix is to detect bool columns with value converters (upon initial translation) and apply comparison with constant true (with the same mapping). Also, we need to recognize this pattern during SqlExpression optimization, so that it' doesn't get simplified from 'a == true' to 'a' Resolves #18147
Hello, our project makes abundant use of I'd like to know why this is currently scheduled for 5.0 when, it seems, it's already fixed. Thank you very much |
…y when value converter is applied" This reverts commit e922850. # Conflicts: # test/EFCore.Specification.Tests/CustomConvertersTestBase.cs # test/EFCore.SqlServer.FunctionalTests/CustomConvertersSqlServerTest.cs # test/EFCore.Sqlite.FunctionalTests/CustomConvertersSqliteTest.cs
…y when value converter is applied" This reverts commit e922850. # Conflicts: # test/EFCore.Specification.Tests/CustomConvertersTestBase.cs # test/EFCore.SqlServer.FunctionalTests/CustomConvertersSqlServerTest.cs # test/EFCore.Sqlite.FunctionalTests/CustomConvertersSqliteTest.cs
…y when value converter is applied" This reverts commit e922850. # Conflicts: # test/EFCore.Specification.Tests/CustomConvertersTestBase.cs # test/EFCore.SqlServer.FunctionalTests/CustomConvertersSqlServerTest.cs # test/EFCore.Sqlite.FunctionalTests/CustomConvertersSqliteTest.cs
…alue converter is applied Added a postprocessor step that identifies bool columns with value converters inside a predicate and modifies them accordingly. Fixes #18147
…alue converter is applied Added a postprocessor step that identifies bool columns with value converters inside a predicate and modifies them accordingly. Fixes #18147
…alue converter is applied Added a postprocessor step that identifies bool columns with value converters inside a predicate and modifies them accordingly. Fixes #18147
…alue converter is applied Added a postprocessor step that identifies bool columns with value converters inside a predicate and modifies them accordingly. Fixes #18147
…alue converter is applied Added a postprocessor step that identifies bool columns with value converters inside a predicate and modifies them accordingly. Fixes #18147
* Upstream issue got fixed: dotnet/efcore#18147 * Upstream issue got fixed: dotnet/efcore#11929 * Fix test that works now.
Generates SQL
It works for SqlServer since SqlServer converts everything to search condition explicitly so generates
The text was updated successfully, but these errors were encountered: