Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't track materialized keyless entity instances #17102

Closed
ajcvickers opened this issue Aug 12, 2019 · 1 comment · Fixed by #17108
Closed

Don't track materialized keyless entity instances #17102

ajcvickers opened this issue Aug 12, 2019 · 1 comment · Fixed by #17108
Assignees
@smitpatel
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
3.0.0

Comments

@ajcvickers
Copy link
Contributor

Rather than making queries the start with or use keyless entities inherently tracking or no-tracking, we will just not track keyless instances in the same way that we don't track other things in the projection that aren't keyed entity types.
@ajcvickers ajcvickers added this to the 3.0.0 milestone Aug 12, 2019
@ajcvickers ajcvickers mentioned this issue Aug 12, 2019
Closed
@smitpatel
Copy link
Contributor

Poaching.

@smitpatel smitpatel assigned smitpatel and unassigned ajcvickers and smitpatel Aug 12, 2019
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 12, 2019
smitpatel added a commit that referenced this issue Aug 12, 2019
@smitpatel
Query: Don't track materialized keyless entity instances
16e314e 
Rather than requiring AsNoTracking in the query.

Resolves #17102
@smitpatel smitpatel mentioned this issue Aug 12, 2019
Merged
smitpatel added a commit that referenced this issue Aug 12, 2019
@smitpatel
Query: Don't track materialized keyless entity instances
7aebe01 
Rather than requiring AsNoTracking in the query.

Resolves #17102
smitpatel added a commit that referenced this issue Aug 13, 2019
@smitpatel
Query: Don't track materialized keyless entity instances
40bcd6c 
Rather than requiring AsNoTracking in the query.

Resolves #17102
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview9 Aug 21, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview9, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Query: Don't track materialized keyless entity instances dotnet/efcore
2 participants
@ajcvickers @smitpatel