Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cosmos: Collection rewrite in navigation causes type error #16392

Closed
smitpatel opened this issue Jul 2, 2019 · 3 comments · Fixed by #16927
Closed

Cosmos: Collection rewrite in navigation causes type error #16392

smitpatel opened this issue Jul 2, 2019 · 3 comments · Fixed by #16927
Assignees
@smitpatel
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
3.0.0

Comments

@smitpatel
Copy link
Contributor 

System.ArgumentException : Expression of type 'System.Collections.Generic.ICollection`1[Microsoft.EntityFrameworkCore.Query.OwnedQueryTestBase`1+Order[Microsoft.EntityFrameworkCore.Cosmos.Query.OwnedQueryCosmosTest+OwnedQueryCosmosFixture]]' cannot be used for parameter of type 'System.Linq.IQueryable`1[Microsoft.EntityFrameworkCore.Query.OwnedQueryTestBase`1+Order[Microsoft.EntityFrameworkCore.Cosmos.Query.OwnedQueryCosmosTest+OwnedQueryCosmosFixture]]' of method 'System.Linq.IQueryable`1[System.Boolean] Select[Order,Boolean](System.Linq.IQueryable`1[Microsoft.EntityFrameworkCore.Query.OwnedQueryTestBase`1+Order[Microsoft.EntityFrameworkCore.Cosmos.Query.OwnedQueryCosmosTest+OwnedQueryCosmosFixture]], System.Linq.Expressions.Expression`1[System.Func`2[Microsoft.EntityFrameworkCore.Query.OwnedQueryTestBase`1+Order[Microsoft.EntityFrameworkCore.Cosmos.Query.OwnedQueryCosmosTest+OwnedQueryCosmosFixture],System.Boolean]])' (Parameter 'arg0')
@smitpatel
Copy link
Contributor Author

Disabled tests
Navigation_rewrite_on_owned_collection
Navigation_rewrite_on_owned_collection_with_composition
Navigation_rewrite_on_owned_collection_with_composition_complex

@AndriySvyryd - Let me know if these tests are blocking you in any way, I can look into re-enabling it sooner.

@AndriySvyryd
Copy link
Member

@smitpatel I think overall owned type support in query is more important atm.

@ajcvickers ajcvickers added this to the 3.0.0 milestone Jul 5, 2019
@smitpatel smitpatel mentioned this issue Jul 27, 2019
Merged
@smitpatel
Copy link
Contributor Author

Blocked on #16620

@smitpatel smitpatel added blocked closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. and removed blocked labels Aug 1, 2019
smitpatel added a commit that referenced this issue Aug 3, 2019
@smitpatel
Query: Add support for owned collections
e0ecbfc 
Resolves #16620
Resolves #16392
Partially fix #15285
smitpatel added a commit that referenced this issue Aug 3, 2019
@smitpatel
Query: Add support for owned collections
8e504f2 
Resolves #16620
Resolves #16392
Partially fix #15285
@smitpatel smitpatel mentioned this issue Aug 3, 2019
Merged
smitpatel added a commit that referenced this issue Aug 3, 2019
@smitpatel
Query: Add support for owned collections (#16927)
49f9f76 
Resolves #16620
Resolves #16392
Partially fix #15285
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview9 Aug 21, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview9, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Query: Add support for owned collections dotnet/efcore
3 participants
@ajcvickers @smitpatel @AndriySvyryd