Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra model annotations from snapshot #15675

Closed
AndriySvyryd opened this issue May 9, 2019 · 2 comments
Closed

Remove extra model annotations from snapshot #15675

AndriySvyryd opened this issue May 9, 2019 · 2 comments
Assignees
@roji
Labels
area-migrations area-scaffolding closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
5.0.0

Comments

@AndriySvyryd
Copy link
Member

AndriySvyryd commented May 9, 2019 •
edited
Loading

Put all the annotations that should be removed in one place that CSharpSnapshotGenerator, MigrationsCodeGenerator and CSharpDbContextGenerator use.

And add tests for ignored model annotations
@ajcvickers
Copy link
Contributor

Putting this on the backlog to make sure that we have test coverage and that the correct annotations are included in the snapshot.

Note that in triage we were not 100% sure whether MaxIdentifierLength should be in the snapshot or not. There may have been MySQL bugs when it wasn't there.

@ajcvickers ajcvickers added this to the Backlog milestone May 10, 2019
@AndriySvyryd AndriySvyryd changed the title Remove MaxIdentifierLength from snapshot Remove extra model annotations from snapshot May 10, 2019
@bricelam bricelam self-assigned this Nov 5, 2019
@AndriySvyryd AndriySvyryd mentioned this issue Feb 8, 2020
Open
6 tasks
@AndriySvyryd AndriySvyryd mentioned this issue Jun 12, 2020
Closed
@roji roji removed this from the Backlog milestone Jun 18, 2020
@roji roji assigned roji and unassigned bricelam Jun 18, 2020
@roji
Copy link
Member

roji commented Jun 18, 2020

Poaching to do as part of the work for #21210

roji added a commit that referenced this issue Jun 18, 2020
@roji
Refactor annotation code generation
58a7b20 
Closes #21210
Closes #15675
@roji roji mentioned this issue Jun 18, 2020
Merged
roji added a commit that referenced this issue Jun 20, 2020
@roji
Refactor annotation code generation
96becc2 
Closes #21210
Closes #15675
@roji roji added this to the 5.0.0 milestone Jun 20, 2020
@roji roji added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 20, 2020
roji added a commit that referenced this issue Jun 20, 2020
@roji
Refactor annotation code generation
c4a2bad 
Closes #16922
Closes #15675
@roji roji closed this as completed in 61f3c0b Jun 20, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview7 Jun 22, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview7, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
area-migrations area-scaffolding closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
4 participants
@bricelam @ajcvickers @roji @AndriySvyryd