Correct ordering of check constraint creation (#21040)

Fixes #21037
dotnet · May 27, 2020 · f244396 · f244396
1 parent 3448ae1
commit f244396
Show file tree

Hide file tree

Showing 4 changed files with 37 additions and 6 deletions.
diff --git a/src/EFCore.Relational/Migrations/Internal/MigrationsModelDiffer.cs b/src/EFCore.Relational/Migrations/Internal/MigrationsModelDiffer.cs
@@ -59,7 +59,12 @@ public class MigrationsModelDiffer : IMigrationsModelDiffer
 
         private static readonly Type[] _columnOperationTypes = { typeof(AddColumnOperation), typeof(AlterColumnOperation) };
 
-        private static readonly Type[] _constraintOperationTypes = { typeof(AddForeignKeyOperation), typeof(CreateIndexOperation) };
+        private static readonly Type[] _constraintOperationTypes =
+        {
+            typeof(AddForeignKeyOperation),
+            typeof(CreateIndexOperation),
+            typeof(CreateCheckConstraintOperation)
+        };
 
         private IUpdateAdapter _sourceUpdateAdapter;
         private IUpdateAdapter _targetUpdateAdapter;
@@ -212,10 +217,6 @@ protected virtual IReadOnlyList<MigrationOperation> Sort(
                 {
                     createSequenceOperations.Add(operation);
                 }
-                else if (type == typeof(CreateCheckConstraintOperation))
-                {
-                    createCheckConstraintOperations.Add(operation);
-                }
                 else if (type == typeof(CreateTableOperation))
                 {
                     createTableOperations.Add((CreateTableOperation)operation);

diff --git a/test/EFCore.Relational.Specification.Tests/MigrationsTestBase.cs b/test/EFCore.Relational.Specification.Tests/MigrationsTestBase.cs
@@ -530,6 +530,22 @@ public virtual Task Add_column_shared()
                     // Assert.Equal("nvarchar(30)", column.StoreType);
                 });
 
+        [ConditionalFact]
+        public virtual Task Add_column_with_check_constraint()
+            => Test(
+                builder => builder.Entity("People").Property<int>("Id"),
+                builder => { },
+                builder => builder.Entity(
+                    "People", e =>
+                    {
+                        e.Property<int>("DriverLicense");
+                        e.HasCheckConstraint("CK_Foo", $"{DelimitIdentifier("DriverLicense")} > 0");
+                    }),
+                model =>
+                {
+                    // TODO: no scaffolding support for check constraints, https://github.com/aspnet/EntityFrameworkCore/issues/15408
+                });
+
         [ConditionalFact]
         public virtual Task Alter_column_change_type()
             => Test(

diff --git a/test/EFCore.SqlServer.FunctionalTests/MigrationsSqlServerTest.cs b/test/EFCore.SqlServer.FunctionalTests/MigrationsSqlServerTest.cs
@@ -28,7 +28,7 @@ public MigrationsSqlServerTest(MigrationsSqlServerFixture fixture, ITestOutputHe
             : base(fixture)
         {
             Fixture.TestSqlLoggerFactory.Clear();
-            Fixture.TestSqlLoggerFactory.SetTestOutputHelper(testOutputHelper);
+            // Fixture.TestSqlLoggerFactory.SetTestOutputHelper(testOutputHelper);
         }
 
         public override async Task Create_table()
@@ -414,6 +414,16 @@ public override async Task Add_column_shared()
                 @"ALTER TABLE [Base] ADD [Foo] nvarchar(max) NULL;");
         }
 
+        public override async Task Add_column_with_check_constraint()
+        {
+            await base.Add_column_with_check_constraint();
+
+            AssertSql(
+                @"ALTER TABLE [People] ADD [DriverLicense] int NOT NULL DEFAULT 0;",
+                //
+                @"ALTER TABLE [People] ADD CONSTRAINT [CK_Foo] CHECK ([DriverLicense] > 0);");
+        }
+
         [ConditionalFact]
         public virtual async Task Add_column_identity()
         {

diff --git a/test/EFCore.Sqlite.FunctionalTests/MigrationsSqliteTest.cs b/test/EFCore.Sqlite.FunctionalTests/MigrationsSqliteTest.cs
@@ -326,6 +326,10 @@ await Test(
                 @"ALTER TABLE ""People"" ADD ""Name"" AS ('hello') COLLATE NOCASE;");
         }
 
+        [ConditionalFact]
+        public override Task Add_column_with_check_constraint()
+            => AssertNotSupportedAsync(base.Add_column_with_check_constraint, SqliteStrings.InvalidMigrationOperation("CreateCheckConstraintOperation"));
+
         public override Task Alter_column_make_required()
             => AssertNotSupportedAsync(base.Alter_column_make_required, SqliteStrings.InvalidMigrationOperation("AlterColumnOperation"));