Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Socket.Close timeout parameter doc #7888

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

deeprobin
Copy link
Contributor

Summary

As described in dotnet/runtime#64860 (comment), this PR provides a fix for seconds -> milliseconds, since setsockopt expects a milliseconds value.

/cc @danmoseley
/cc @stephentoub

@ghost
Copy link

ghost commented Mar 28, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Summary

As described in dotnet/runtime#64860 (comment), this PR provides a fix for seconds -> milliseconds, since setsockopt expects a milliseconds value.

/cc @danmoseley
/cc @stephentoub

Author: deeprobin
Assignees: -
Labels:

area-System.Net.Sockets

Milestone: -

Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. Please ensure that the XML comments in the code also say milliseconds.

@deeprobin
Copy link
Contributor Author

thanks. Please ensure that the XML comments in the code also say milliseconds.

In the current code this is undocumented.

@opbld30
Copy link

opbld30 commented Mar 28, 2022

Docs Build status updates of commit 4ec523c:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Sockets/Socket.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@gewarren gewarren merged commit 507984c into dotnet:main Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants