Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CC85037: Fixing link #9374

Merged
merged 1 commit into from
Dec 4, 2018
Merged

CC85037: Fixing link #9374

merged 1 commit into from
Dec 4, 2018

Conversation

v-makoud
Copy link
Contributor

@v-makoud v-makoud commented Dec 4, 2018

Hello, @mairaw, @dend, @Rick-Anderson,
This proposed file change comes from https://github.com/dotnet/docs.de-de/pull/114 .
Could you review this contribution and help to merge if agreed?
Many thanks in advance.

Summary

Describe your changes here.

Fixes #Issue_Number (if available)

Hello, @mairaw, @dend, @Rick-Anderson,
This proposed file change comes from https://github.com/dotnet/docs.de-de/pull/114 .
Could you review this contribution and help to merge if agreed?
Many thanks in advance.
@mairaw mairaw added loc Indicates issues that are about localized content [org][type][category] blocked Blocked for some reason WIP waiting-on-feedback Waiting for feedback from SMEs before they can be merged labels Dec 4, 2018
@mairaw
Copy link
Contributor

mairaw commented Dec 4, 2018

Not sure if we can accept this PR @v-makoud. This will work for de-de but it doesn't seem that the same file has been added to other locales, so it will break the other languages. @JasonCard can you please help with this PR and what we should do here?

@JasonCard
Copy link
Contributor

@mairaw I'm not sure why CONTRIBUTING.md was only localized for de-de, but I've corrected this, so it will be localized for all locales. Please go ahead to accept this PR now, as link will fallback to English version even when it does not exist in loc repos yet. cc @v-makoud

@mairaw mairaw removed WIP blocked Blocked for some reason waiting-on-feedback Waiting for feedback from SMEs before they can be merged labels Dec 4, 2018
@mairaw
Copy link
Contributor

mairaw commented Dec 4, 2018

With this change, it'll always look for that file in the repo and not fallback to en-us.

@mairaw mairaw merged commit 6815c82 into dotnet:master Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
loc Indicates issues that are about localized content [org][type][category]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants