Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc Breaking Changes #44712

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Misc Breaking Changes #44712

merged 2 commits into from
Feb 7, 2025

Conversation

CamSoper
Copy link
Contributor

@CamSoper CamSoper commented Feb 7, 2025

@CamSoper CamSoper requested review from gewarren and a team as code owners February 7, 2025 02:10
@dotnetrepoman dotnetrepoman bot added this to the February 2025 milestone Feb 7, 2025
@CamSoper CamSoper requested a review from BillWagner as a code owner February 7, 2025 02:16
@CamSoper CamSoper enabled auto-merge (squash) February 7, 2025 02:23
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @CamSoper

Let's :shipit:

@CamSoper CamSoper merged commit 4359103 into dotnet:main Feb 7, 2025
8 checks passed
@gewarren
Copy link
Contributor

gewarren commented Feb 7, 2025

@CamSoper Reading the BC issue, I'm not sure this is the right fix. It's still a breaking change in .NET 9, so that article needs to remain. I think the right fix is to update the article to note that in .NET 10 (and perhaps also in .NET 9 servicing), it's no longer a breaking change, and add the remarks that Tanya added.

@CamSoper
Copy link
Contributor Author

CamSoper commented Feb 7, 2025

You know what, @gewarren, I think you may be right. I think I misunderstood Tanya's last comment on the original issue that created this. I'll reopen the issue and figure it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Breaking change]: System.Windows.Forms.StatusStrip in NET9 will use the same renderer as in NET8 and before.
3 participants