Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Attribute Retrieval Guide to Include Member-Level Attributes #44665

Merged
merged 11 commits into from
Feb 6, 2025

Conversation

shethaadit
Copy link
Contributor

@shethaadit shethaadit commented Feb 3, 2025

Summary

Updated the documentation on retrieving information stored in attributes to include details on reading attributes applied to class members.

  • Expanded explanations to cover member-level attribute retrieval.
  • Clarified usage of GetCustomAttribute and GetCustomAttributes for different scopes.
  • Ensured consistency in terminology and improved readability.

Fixes #40174


Internal previews

📄 File 🔗 Preview link
docs/standard/attributes/retrieving-information-stored-in-attributes.md Retrieving Information Stored in Attributes

@shethaadit shethaadit requested review from gewarren and a team as code owners February 3, 2025 18:37
@dotnetrepoman dotnetrepoman bot added this to the February 2025 milestone Feb 3, 2025
@dotnet-policy-service dotnet-policy-service bot added dotnet-fundamentals/svc community-contribution Indicates PR is created by someone from the .NET community. labels Feb 3, 2025
shethaadit and others added 3 commits February 4, 2025 11:32
Co-authored-by: Bartosz Klonowski <[email protected]>
Co-authored-by: Bartosz Klonowski <[email protected]>
Co-authored-by: Bartosz Klonowski <[email protected]>
@shethaadit
Copy link
Contributor Author

Thank you @BartoszKlonowski for your suggestions. I have applied those. :)
cc: @BillWagner

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shethaadit

I reviewed everything, and it looks great. Before I merge it, can you move the sample into a project in a snippets folder so it's under our CI system? That helps us ensure the code is always up to date.

Thanks.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the perseverance on this @shethaadit

I'll :shipit: now.

@BillWagner BillWagner merged commit 90c1904 into dotnet:main Feb 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reading attributes: Update and add more info
3 participants