Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default value for csharp_space_between_parentheses #44623

Merged
merged 2 commits into from
Feb 1, 2025
Merged

Add default value for csharp_space_between_parentheses #44623

merged 2 commits into from
Feb 1, 2025

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Jan 30, 2025 •
edited by github-actions bot
Loading

Fixes #37130

  • Add default value for csharp_space_between_parentheses, and clarify false value
  • Also formats other tables in doc (so hide whitespace changes)

Internal previews

📄 File 🔗 Preview link
docs/fundamentals/code-analysis/style-rules/csharp-formatting-options.md C# formatting options

@gewarren gewarren requested a review from a team as a code owner January 30, 2025 18:19
@dotnetrepoman dotnetrepoman bot added this to the January 2025 milestone Jan 30, 2025
BillWagner
BillWagner approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

You can :shipit: when ready.

@gewarren gewarren merged commit b4355ea into dotnet:main Feb 1, 2025
11 checks passed
@gewarren gewarren deleted the space-between-parens branch February 1, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
January 2025
Development

Successfully merging this pull request may close these issues.

Roslyn style rules csharp_space_between_parentheses don't have false value in doc
2 participants
@gewarren @BillWagner