Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 'return' keyword in sample code #44506

Merged
merged 1 commit into from
Jan 27, 2025
Merged

add 'return' keyword in sample code #44506

merged 1 commit into from
Jan 27, 2025

Conversation

ShaoHans
Copy link
Contributor

@ShaoHans ShaoHans commented Jan 24, 2025 •
edited by github-actions bot
Loading

Summary

In this page https://learn.microsoft.com/en-us/dotnet/orleans/grains/grain-identity ,the sample code lack the 'return' keyword
image

Internal previews

📄 File 🔗 Preview link
docs/orleans/grains/grain-identity.md Grain identity

@ShaoHans ShaoHans requested review from IEvangelist and a team as code owners January 24, 2025 07:22
@dotnetrepoman dotnetrepoman bot added this to the January 2025 milestone Jan 24, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label Jan 24, 2025
BillWagner
BillWagner approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Thanks @ShaoHans

I'll :shipit: now.

@BillWagner BillWagner enabled auto-merge (squash) January 27, 2025 14:23
@BillWagner BillWagner merged commit dd3a94f into dotnet:main Jan 27, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@IEvangelist IEvangelist Awaiting requested review from IEvangelist IEvangelist is a code owner

Assignees
No one assigned
Labels
community-contribution Indicates PR is created by someone from the .NET community.
Projects
None yet
Milestone
January 2025
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaoHans @BillWagner