-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Jammy instructions #30666
Merged
Update Jammy instructions #30666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adegeo
requested changes
Aug 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall a good change. Two major things need to change:
- Is the SDK still supported via the MS feeds? Users are reporting it's missing. If it's no longer supported, the section for 22.04 - MS Feed is going to have to change it's include files.
- The body of 22.04 which lists the install instructions for the normal jammy feeds should follow the style of the include file, even though the content is slightly different (no adding a feed). Duplicate what is there and adjust it accordingly: https://raw.githubusercontent.com/dotnet/docs/c8319eb9f2f07ca1b4ddc9ff25e4b9d2ebbb9c98/docs/core/install/includes/linux-install-60-apt.md
Co-authored-by: Andy (Steve) De George <[email protected]>
I believe I got everything. There is no change in the SDK as part of this. |
adegeo
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions have changed for Ubuntu 22.04.
It appears like this doc may need to be re-structured. We need to update the instructions as a higher priority than considering broader changes.
Fixes #30686