Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definition of examineNumber was never used #18490

Merged
merged 1 commit into from
May 18, 2020
Merged

Conversation

xerxesb
Copy link
Contributor

@xerxesb xerxesb commented May 18, 2020

Summary

The second sample for Partial Active Patterns in F# defined a function examineNumber, but this function was never used in printing the output of squares and cubes. I believe it is leftover after an older example was changed, and should be removed as it's confusing for someone new to active patterns.

The sample defined a function `examineNumber`, but this function was never used in printing the output of squares and cubes. I believe it is leftover after an older example was changed, and should be removed as it's confusing.
@xerxesb xerxesb requested a review from cartermp as a code owner May 18, 2020 21:57
@dotnet-bot dotnet-bot added this to the May 2020 milestone May 18, 2020
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch!

@cartermp cartermp merged commit 344cbb2 into dotnet:master May 18, 2020
@xerxesb xerxesb deleted the patch-1 branch May 19, 2020 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants