Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for dotnet test issues #18167

Merged
merged 6 commits into from
Apr 30, 2020
Merged

Updates for dotnet test issues #18167

merged 6 commits into from
Apr 30, 2020

Conversation

tdykstra
Copy link
Contributor

@tdykstra tdykstra commented Apr 29, 2020 •
edited
Loading

Fixes #2382
Fixes #12551
Fixes #13749
Fixes #14739

@tdykstra tdykstra requested a review from a team as a code owner April 29, 2020 22:10
@dotnet-bot dotnet-bot added this to the May 2020 milestone Apr 29, 2020
@tdykstra tdykstra requested review from BillWagner and removed request for a team April 29, 2020 22:16
BillWagner
BillWagner approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @tdykstra

You can :shipit: when ready.

@tdykstra tdykstra merged commit cff6f53 into dotnet:master Apr 30, 2020
@tdykstra tdykstra deleted the dotnettest branch April 30, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees
No one assigned
Labels
cli/subsvc
Projects
None yet
Milestone
May 2020
3 participants
@tdykstra @BillWagner @dotnet-bot