-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Returning Task without awaiting it is contradictory to MSFT employee's advice #16187
Comments
Thanks for writing this @georg-jung Whether to await or directly return a Task is a recommendation with a lot of subtleties. We should explain it better. The reason behind the subtleties is how synchronous and asynchronous methods differ: For any method with the The creation of the state machine ensures that resources aren't disposed of while still needed for asynchronous tasks. That fact leads to recommending that methods that return a The code in this article points to another reason to (sometimes) return a Task from a synchronous method: to ensure that exceptions stemming from programming errors are thrown synchronously. Jon Skeet and I have both advocated this because it makes debugging easier for developers using your APIs. We should update this article (and a few others in the async project) to include these subtleties. /cc @stephentoub |
This is a subtle topic. It would be great to have it covered in a single authoritative place. Cheers! |
This issue has been closed as part of the issue backlog grooming process outlined in #22351. That automated process may have closed some issues that should be addressed. If you think this is one of them, reopen it with a comment explaining why. Tag the |
@BillWagner as you mentioned above, it would be good to have documentation for this topic somewhere. Or is it just too low priority relative to bugs? |
Fixes dotnet#16187 The usage of synchronous Task-returning methods is not generally recommended. See https://github.com/davidfowl/AspNetCoreDiagnosticScenarios/blob/master/AsyncGuidance.md#prefer-asyncawait-over-directly-returning-task The examples were valid, but can cause hard-to-diagnose issues. As we add more advanced async scenarios, this scenario belongs there, with more details about when it is and isn't appropriate. (`using` in the non-async method is the primary mistake to run into).
Fixes #16187 The usage of synchronous Task-returning methods is not generally recommended. See https://github.com/davidfowl/AspNetCoreDiagnosticScenarios/blob/master/AsyncGuidance.md#prefer-asyncawait-over-directly-returning-task The examples were valid, but can cause hard-to-diagnose issues. As we add more advanced async scenarios, this scenario belongs there, with more details about when it is and isn't appropriate. (`using` in the non-async method is the primary mistake to run into).
* update metadata (#22916) I had added the wrong ms.custom value * update links to ECMA standards (#22942) * update links to ECMA standards ECMA launched an updated website early this year. This PR updates links to ECMA 334 (C#), ECMA 335 (CLI), and TR-84 (XML data formats) * fix build error. Missing opening parenthesis in link. * clarify defensive copies (#22996) Fixes #21691 - Clarify the rules for defensive copies Fixes #22955 - Provide link to conceptual doc with examples. * remove discussion of Task-returning non-async methods (#23001) Fixes #16187 The usage of synchronous Task-returning methods is not generally recommended. See https://github.com/davidfowl/AspNetCoreDiagnosticScenarios/blob/master/AsyncGuidance.md#prefer-asyncawait-over-directly-returning-task The examples were valid, but can cause hard-to-diagnose issues. As we add more advanced async scenarios, this scenario belongs there, with more details about when it is and isn't appropriate. (`using` in the non-async method is the primary mistake to run into). * How to compare strings: correct the list of ordinal-comparison operations (#23007) * fix typo (#23033) `GenEnvVariable` didn't appear in csharp/tutorials/AsyncStreams/start/IssuePRreport/IssuePRreport/Program.cs . so I think it's typo, I'm just getting start in c# and not sure this should be `GetEnvVariable`. Some of issue mention GetEnvVariable and didn't say it's typo , so sorry if it's already correct. Also sorry for my suck English. * Adding hyperlink to reference types (#23038) * Discards article: Fix the section about the discard pattern (#23039) * Discards article: Fix the section about the discard pattern * Update docs/csharp/discards.md Co-authored-by: Bill Wagner <[email protected]> Co-authored-by: Bill Wagner <[email protected]> * fix wrong URL (#23047) [C# Reference] URL is wrong. It's same with [C# Programming Guide] URL as above. * Bump MSTest.TestAdapter (#23053) Bumps [MSTest.TestAdapter](https://github.com/microsoft/testfx) from 2.1.2 to 2.2.1. - [Release notes](https://github.com/microsoft/testfx/releases) - [Commits](microsoft/testfx@v2.1.2...v2.2.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump MSTest.TestFramework (#23051) Bumps [MSTest.TestFramework](https://github.com/microsoft/testfx) from 2.1.2 to 2.2.1. - [Release notes](https://github.com/microsoft/testfx/releases) - [Commits](microsoft/testfx@v2.1.2...v2.2.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump MSTest.TestFramework (#23056) Bumps [MSTest.TestFramework](https://github.com/microsoft/testfx) from 2.1.2 to 2.2.1. - [Release notes](https://github.com/microsoft/testfx/releases) - [Commits](microsoft/testfx@v2.1.2...v2.2.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump MSTest.TestAdapter (#23059) Bumps [MSTest.TestAdapter](https://github.com/microsoft/testfx) from 2.1.2 to 2.2.1. - [Release notes](https://github.com/microsoft/testfx/releases) - [Commits](microsoft/testfx@v2.1.2...v2.2.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump MSTest.TestAdapter (#23061) Bumps [MSTest.TestAdapter](https://github.com/microsoft/testfx) from 2.1.2 to 2.2.1. - [Release notes](https://github.com/microsoft/testfx/releases) - [Commits](microsoft/testfx@v2.1.2...v2.2.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update additional-resources.md (#23077) * Bump MSTest.TestAdapter (#23055) Bumps [MSTest.TestAdapter](https://github.com/microsoft/testfx) from 2.1.2 to 2.2.1. - [Release notes](https://github.com/microsoft/testfx/releases) - [Commits](microsoft/testfx@v2.1.2...v2.2.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump MSTest.TestFramework (#23062) Bumps [MSTest.TestFramework](https://github.com/microsoft/testfx) from 2.1.2 to 2.2.1. - [Release notes](https://github.com/microsoft/testfx/releases) - [Commits](microsoft/testfx@v2.1.2...v2.2.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.CodeAnalysis (#23092) Bumps [Microsoft.CodeAnalysis](https://github.com/dotnet/roslyn) from 3.8.0 to 3.9.0. - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/master/docs/Breaking%20API%20Changes.md) - [Commits](dotnet/roslyn@v3.8.0...v3.9.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.CodeAnalysis.CSharp.Workspaces (#23090) Bumps [Microsoft.CodeAnalysis.CSharp.Workspaces](https://github.com/dotnet/roslyn) from 3.8.0 to 3.9.0. - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/master/docs/Breaking%20API%20Changes.md) - [Commits](dotnet/roslyn@v3.8.0...v3.9.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.CodeAnalysis.CSharp.Workspaces (#23091) Bumps [Microsoft.CodeAnalysis.CSharp.Workspaces](https://github.com/dotnet/roslyn) from 3.8.0 to 3.9.0. - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/master/docs/Breaking%20API%20Changes.md) - [Commits](dotnet/roslyn@v3.8.0...v3.9.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.CodeAnalysis.CSharp.Workspaces (#23087) Bumps [Microsoft.CodeAnalysis.CSharp.Workspaces](https://github.com/dotnet/roslyn) from 3.8.0 to 3.9.0. - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/master/docs/Breaking%20API%20Changes.md) - [Commits](dotnet/roslyn@v3.8.0...v3.9.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix non compilable code (#23095) * Fix non compliable code The sample code doesn't compile. * Update docs/core/diagnostics/distributed-tracing.md Co-authored-by: Youssef Victor <[email protected]> * Apply suggestions from code review Co-authored-by: Youssef Victor <[email protected]> Co-authored-by: Youssef Victor <[email protected]> Co-authored-by: Bill Wagner <[email protected]> * Bump Microsoft.CodeAnalysis.CSharp.Workspaces (#23089) Bumps [Microsoft.CodeAnalysis.CSharp.Workspaces](https://github.com/dotnet/roslyn) from 3.8.0 to 3.9.0. - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/master/docs/Breaking%20API%20Changes.md) - [Commits](dotnet/roslyn@v3.8.0...v3.9.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.CodeAnalysis.CSharp.Workspaces (#23086) Bumps [Microsoft.CodeAnalysis.CSharp.Workspaces](https://github.com/dotnet/roslyn) from 3.8.0 to 3.9.0. - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/master/docs/Breaking%20API%20Changes.md) - [Commits](dotnet/roslyn@v3.8.0...v3.9.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Remove dotnet-trace ps from memory leak tutorial (#23074) * Bump MSTest.TestFramework (#23060) Bumps [MSTest.TestFramework](https://github.com/microsoft/testfx) from 2.1.2 to 2.2.1. - [Release notes](https://github.com/microsoft/testfx/releases) - [Commits](microsoft/testfx@v2.1.2...v2.2.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump coverlet.collector (#22935) Bumps [coverlet.collector](https://github.com/coverlet-coverage/coverlet) from 3.0.2 to 3.0.3. - [Release notes](https://github.com/coverlet-coverage/coverlet/releases) - [Commits](https://github.com/coverlet-coverage/coverlet/commits) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add section about EF Core events in well known events doc (#22828) * Add section about EF Core events in well known events doc * linter error * Update docs/core/diagnostics/well-known-event-providers.md Co-authored-by: John Salem <[email protected]> Co-authored-by: John Salem <[email protected]> * Update download path (#22909) * Update download path * feedback * feedback Co-authored-by: Bill Wagner <[email protected]> * set topic type to reference for WCF diagnostics (#22819) * delete unimplemented rule doc (#22799) * Change EventPipe environment variables that went out of sync (#22947) * Parallel.ForEach should not be used for IO bound tasks (#22957) * Parallel.ForEach with CPU intensive operations * Refactored as per the code review comments * Fix ICorProfilerInfo9 .NET Core version, Fix COR_PRF_REJIT_FLAGS .NET Core version (#22964) * Correct ICorProfilerInfo9 available since .NET Core 2.1 * Correct that COR_PRF_REJIT_FLAGS was available in .NET Core 3.0 (ICorProfilerInfo10) * Cleanup .NET Core 2.2 include * Fix link to CA2247 (#22963) * update VS 'talk to us' link text (#23002) * Fix WF cookbook links (#23018) * Add preview 2 nullability changes (#23019) * Bump Octokit (#22933) Bumps [Octokit](https://github.com/octokit/octokit.net) from 0.49.0 to 0.50.0. - [Release notes](https://github.com/octokit/octokit.net/releases) - [Changelog](https://github.com/octokit/octokit.net/blob/main/ReleaseNotes.md) - [Commits](octokit/octokit.net@v0.49.0...v0.50.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Octokit (#22934) Bumps [Octokit](https://github.com/octokit/octokit.net) from 0.49.0 to 0.50.0. - [Release notes](https://github.com/octokit/octokit.net/releases) - [Changelog](https://github.com/octokit/octokit.net/blob/main/ReleaseNotes.md) - [Commits](octokit/octokit.net@v0.49.0...v0.50.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Require space before DU constructor arguments (#23094) * Bump Microsoft.NET.Test.Sdk (#22973) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](microsoft/vstest@v16.8.3...v16.9.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.NET.Test.Sdk (#22974) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](microsoft/vstest@v16.8.3...v16.9.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.NET.Test.Sdk (#22975) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](microsoft/vstest@v16.8.3...v16.9.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.NET.Test.Sdk in /samples/snippets/csharp/xunit-test (#22976) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](microsoft/vstest@v16.8.3...v16.9.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.NET.Test.Sdk (#22977) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](microsoft/vstest@v16.8.3...v16.9.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.NET.Test.Sdk (#22979) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](microsoft/vstest@v16.8.3...v16.9.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Remove DNX content (#22919) * Add breaking change from 2.0-2.1 (#22917) * breaking change from 2.0-2.1 * Update includes/core-changes/msbuild/2.1/dotnetclitoolreference.md Co-authored-by: Genevieve Warren <[email protected]> * Update includes/core-changes/msbuild/2.1/dotnetclitoolreference.md * Update msbuild file * Update msbuild file date * Update toc/title Co-authored-by: Genevieve Warren <[email protected]> * Bump Microsoft.NET.Test.Sdk (#22980) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](microsoft/vstest@v16.8.3...v16.9.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.NET.Test.Sdk (#22982) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](microsoft/vstest@v16.8.3...v16.9.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.NET.Test.Sdk (#22981) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](microsoft/vstest@v16.8.3...v16.9.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.NET.Test.Sdk (#22984) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](microsoft/vstest@v16.8.3...v16.9.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.NET.Test.Sdk (#22986) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](microsoft/vstest@v16.8.3...v16.9.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Moq (#22978) Bumps [Moq](https://github.com/moq/moq4) from 4.16.0 to 4.16.1. - [Release notes](https://github.com/moq/moq4/releases) - [Changelog](https://github.com/moq/moq4/blob/main/CHANGELOG.md) - [Commits](devlooped/moq@v4.16.0...v4.16.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Moq (#22985) Bumps [Moq](https://github.com/moq/moq4) from 4.16.0 to 4.16.1. - [Release notes](https://github.com/moq/moq4/releases) - [Changelog](https://github.com/moq/moq4/blob/main/CHANGELOG.md) - [Commits](devlooped/moq@v4.16.0...v4.16.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.NET.Test.Sdk (#22987) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](microsoft/vstest@v16.8.3...v16.9.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add missing prefixes for dotnet tool install (#23042) * Bump Microsoft.NET.Test.Sdk (#22990) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](microsoft/vstest@v16.8.3...v16.9.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.NET.Test.Sdk (#22989) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](microsoft/vstest@v16.8.3...v16.9.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add a note to dotnet nuget add source (#22938) * Explain pseudo-code (#22693) * Fix line numbers for syntax highlighting (#23025) * Fix line numbers for syntax highlighting * Update docs/standard/security/cryptography-model.md * Numeric parsing precision breaking change (#23046) * Added rationale section per #22886 (#22907) * Added rationale section per #22886 * Apply suggestions from code review Co-authored-by: Bill Wagner <[email protected]> * Apply suggestions from code review Co-authored-by: Genevieve Warren <[email protected]> Co-authored-by: Bill Wagner <[email protected]> Co-authored-by: Genevieve Warren <[email protected]> * Add details about "." in env var name (#22915) * Added cross-platform bits for env vars, and note/link re: . in names * Pre-commit hook, applied automatic markdownlint CLI fixes * Apply suggestions from code review * Create version-sweeper workflow YML file (#22931) * Create version-sweep.yml * Update .github/workflows/version-sweep.yml * added link for porting ebook in dotnet arch (#22965) * Porting eBook: add upgrade references (#22930) * add upgrade references * fix trailing spaces * Apply suggestions from code review Co-authored-by: David Pine <[email protected]> Co-authored-by: David Pine <[email protected]> * Explain Dockerfile in detail (#23012) * Address #22941 * Clean up, revery some of the crazy auto formating. * Even more auto format fixes * Fix MD linter violation * Update image syntax, this gives the grey border by default which was missing. * Remove second explaination, as it is a bit redundant. * Initial import of chapter and images * Updating image paths and styling * Update master to main * Remove update of .NET framework after upgrade * Linting updates * Linting updates * Linting update * Update page url in index * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix spelling Co-authored-by: Sumit Ghosh <[email protected]> * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix spelling Co-authored-by: Sumit Ghosh <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-build.md Co-authored-by: Beth Massi <[email protected]> * Update spelling Co-authored-by: Scott Addie <[email protected]> * Adding comma Co-authored-by: Scott Addie <[email protected]> * Fix casing Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Change click to select Co-authored-by: Scott Addie <[email protected]> * Change click to select Co-authored-by: Scott Addie <[email protected]> * Contractions Co-authored-by: Scott Addie <[email protected]> * Contractions and update of "click" to "select" Co-authored-by: Scott Addie <[email protected]> * Grammar fix Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Fix casing Co-authored-by: Scott Addie <[email protected]> * Fix casing Co-authored-by: Scott Addie <[email protected]> * Fix emphasis Co-authored-by: Scott Addie <[email protected]> * Add emphasis Co-authored-by: Scott Addie <[email protected]> * Fix grammar Co-authored-by: Scott Addie <[email protected]> * Make active Co-authored-by: Scott Addie <[email protected]> * Add comma Co-authored-by: Scott Addie <[email protected]> * Fix grammar Co-authored-by: Scott Addie <[email protected]> * Update case Co-authored-by: Scott Addie <[email protected]> * Add missing word Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Fix URL Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Indenting snippets * Various review changes * Update grammar Co-authored-by: Scott Addie <[email protected]> * Change "click" to "select" * Various final edits * Adding deployment article * Linting * Linting * Linting * Linting * Starting to add codeql * Style updates * Initial codeql article * Adding actions v pipelines article * Adding Actions index page * Fix casing on title Co-authored-by: Scott Addie <[email protected]> * Fix casing Co-authored-by: Scott Addie <[email protected]> * Fix casing Co-authored-by: Scott Addie <[email protected]> * Update markdownlint.yml * Linting * Linting * Linting * Linting * Various edits for review * More edits for review process * Casing and spelling updates * Spelling and casing * Casing updates * More edits * edit pass * Updating main index * Edits for review process * More edits for review * Remove bullet * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Another round of edits * Fix click * Edits to grammar * Fix casing * Fix acronym * Grammar edits * More review changes * Adding retain version to URLs * Grammar edits * Grammer fix * Revert "Merge branch 'master' into devops-ebook-actions-index" This reverts commit 4b812a1, reversing changes made to 665e058. * Revert "Grammar edits" This reverts commit d9a3353. * Various style edits * edit pass * react to build suggestions * fix broken ToC link * Update docs/architecture/devops-for-aspnet-developers/toc.yml * edit pass Co-authored-by: Bill Wagner <[email protected]> Co-authored-by: Petr Kulikov <[email protected]> Co-authored-by: DeadBushSanpai <[email protected]> Co-authored-by: sampreeth1999 <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Youssef Victor <[email protected]> Co-authored-by: Paulo Morgado <[email protected]> Co-authored-by: Sung Yoon Whang <[email protected]> Co-authored-by: John Salem <[email protected]> Co-authored-by: Maira Wenzel <[email protected]> Co-authored-by: Genevieve Warren <[email protected]> Co-authored-by: Surender Singh <[email protected]> Co-authored-by: Morgan Creekmore <[email protected]> Co-authored-by: Christer van der Meeren <[email protected]> Co-authored-by: Andy De George <[email protected]> Co-authored-by: Tom Dykstra <[email protected]> Co-authored-by: David Pine <[email protected]> Co-authored-by: Sreenivasulu Kalluru <[email protected]> Co-authored-by: Steve Smith <[email protected]> Co-authored-by: Sumit Ghosh <[email protected]> Co-authored-by: Beth Massi <[email protected]> Co-authored-by: Scott Addie <[email protected]>
* Included DevOps with ASP.NET Core and Azure eBook (#23098) * Included DevOps with ASP.NET Core and Azure eBook * Fixed lint error. * Update docs/architecture/toc.yml Co-authored-by: Nish Anil <[email protected]> Co-authored-by: Nish Anil <[email protected]> * Included toc yaml for devops ebook * Devops ebook (#23137) * Initial import of chapter and images * Updating image paths and styling * Update master to main * Remove update of .NET framework after upgrade * Linting updates * Linting updates * Linting update * Update page url in index * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix spelling Co-authored-by: Sumit Ghosh <[email protected]> * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix spelling Co-authored-by: Sumit Ghosh <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-build.md Co-authored-by: Beth Massi <[email protected]> * Update spelling Co-authored-by: Scott Addie <[email protected]> * Adding comma Co-authored-by: Scott Addie <[email protected]> * Fix casing Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Change click to select Co-authored-by: Scott Addie <[email protected]> * Change click to select Co-authored-by: Scott Addie <[email protected]> * Contractions Co-authored-by: Scott Addie <[email protected]> * Contractions and update of "click" to "select" Co-authored-by: Scott Addie <[email protected]> * Grammar fix Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Fix casing Co-authored-by: Scott Addie <[email protected]> * Fix casing Co-authored-by: Scott Addie <[email protected]> * Fix emphasis Co-authored-by: Scott Addie <[email protected]> * Add emphasis Co-authored-by: Scott Addie <[email protected]> * Fix grammar Co-authored-by: Scott Addie <[email protected]> * Make active Co-authored-by: Scott Addie <[email protected]> * Add comma Co-authored-by: Scott Addie <[email protected]> * Fix grammar Co-authored-by: Scott Addie <[email protected]> * Update case Co-authored-by: Scott Addie <[email protected]> * Add missing word Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Fix URL Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Indenting snippets * Various review changes * Update grammar Co-authored-by: Scott Addie <[email protected]> * Change "click" to "select" * Various final edits Co-authored-by: Sumit Ghosh <[email protected]> Co-authored-by: Beth Massi <[email protected]> Co-authored-by: Scott Addie <[email protected]> * Adding GitHub Actions .NET Deployment Article (#23332) * Initial import of chapter and images * Updating image paths and styling * Update master to main * Remove update of .NET framework after upgrade * Linting updates * Linting updates * Linting update * Update page url in index * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix spelling Co-authored-by: Sumit Ghosh <[email protected]> * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix spelling Co-authored-by: Sumit Ghosh <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-build.md Co-authored-by: Beth Massi <[email protected]> * Update spelling Co-authored-by: Scott Addie <[email protected]> * Adding comma Co-authored-by: Scott Addie <[email protected]> * Fix casing Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Change click to select Co-authored-by: Scott Addie <[email protected]> * Change click to select Co-authored-by: Scott Addie <[email protected]> * Contractions Co-authored-by: Scott Addie <[email protected]> * Contractions and update of "click" to "select" Co-authored-by: Scott Addie <[email protected]> * Grammar fix Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Fix casing Co-authored-by: Scott Addie <[email protected]> * Fix casing Co-authored-by: Scott Addie <[email protected]> * Fix emphasis Co-authored-by: Scott Addie <[email protected]> * Add emphasis Co-authored-by: Scott Addie <[email protected]> * Fix grammar Co-authored-by: Scott Addie <[email protected]> * Make active Co-authored-by: Scott Addie <[email protected]> * Add comma Co-authored-by: Scott Addie <[email protected]> * Fix grammar Co-authored-by: Scott Addie <[email protected]> * Update case Co-authored-by: Scott Addie <[email protected]> * Add missing word Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Fix URL Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Indenting snippets * Various review changes * Update grammar Co-authored-by: Scott Addie <[email protected]> * Change "click" to "select" * Various final edits * Adding deployment article * Linting * Linting * Linting * Linting * Style updates * Fix casing on title Co-authored-by: Scott Addie <[email protected]> * Fix casing Co-authored-by: Scott Addie <[email protected]> * Fix casing Co-authored-by: Scott Addie <[email protected]> * Various edits for review * More edits for review process * More edits * edit pass Co-authored-by: Sumit Ghosh <[email protected]> Co-authored-by: Beth Massi <[email protected]> Co-authored-by: Scott Addie <[email protected]> * CodeQL Article (#23392) * Initial import of chapter and images * Updating image paths and styling * Update master to main * Remove update of .NET framework after upgrade * Linting updates * Linting updates * Linting update * Update page url in index * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix spelling Co-authored-by: Sumit Ghosh <[email protected]> * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix spelling Co-authored-by: Sumit Ghosh <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-build.md Co-authored-by: Beth Massi <[email protected]> * Update spelling Co-authored-by: Scott Addie <[email protected]> * Adding comma Co-authored-by: Scott Addie <[email protected]> * Fix casing Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Change click to select Co-authored-by: Scott Addie <[email protected]> * Change click to select Co-authored-by: Scott Addie <[email protected]> * Contractions Co-authored-by: Scott Addie <[email protected]> * Contractions and update of "click" to "select" Co-authored-by: Scott Addie <[email protected]> * Grammar fix Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Fix casing Co-authored-by: Scott Addie <[email protected]> * Fix casing Co-authored-by: Scott Addie <[email protected]> * Fix emphasis Co-authored-by: Scott Addie <[email protected]> * Add emphasis Co-authored-by: Scott Addie <[email protected]> * Fix grammar Co-authored-by: Scott Addie <[email protected]> * Make active Co-authored-by: Scott Addie <[email protected]> * Add comma Co-authored-by: Scott Addie <[email protected]> * Fix grammar Co-authored-by: Scott Addie <[email protected]> * Update case Co-authored-by: Scott Addie <[email protected]> * Add missing word Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Fix URL Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Indenting snippets * Various review changes * Update grammar Co-authored-by: Scott Addie <[email protected]> * Change "click" to "select" * Various final edits * Adding deployment article * Linting * Linting * Linting * Linting * Starting to add codeql * Style updates * Initial codeql article * Fix casing on title Co-authored-by: Scott Addie <[email protected]> * Fix casing Co-authored-by: Scott Addie <[email protected]> * Fix casing Co-authored-by: Scott Addie <[email protected]> * Linting * Linting * Various edits for review * More edits for review process * Casing and spelling updates * More edits * edit pass * Edits for review process * More edits for review * Remove bullet * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Another round of edits * Fix click Co-authored-by: Sumit Ghosh <[email protected]> Co-authored-by: Beth Massi <[email protected]> Co-authored-by: Scott Addie <[email protected]> * DevOps eBook: GitHub Actions vs Azure Pipelines (#23441) * Initial import of chapter and images * Updating image paths and styling * Update master to main * Remove update of .NET framework after upgrade * Linting updates * Linting updates * Linting update * Update page url in index * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix spelling Co-authored-by: Sumit Ghosh <[email protected]> * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix spelling Co-authored-by: Sumit Ghosh <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-build.md Co-authored-by: Beth Massi <[email protected]> * Update spelling Co-authored-by: Scott Addie <[email protected]> * Adding comma Co-authored-by: Scott Addie <[email protected]> * Fix casing Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Change click to select Co-authored-by: Scott Addie <[email protected]> * Change click to select Co-authored-by: Scott Addie <[email protected]> * Contractions Co-authored-by: Scott Addie <[email protected]> * Contractions and update of "click" to "select" Co-authored-by: Scott Addie <[email protected]> * Grammar fix Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Fix casing Co-authored-by: Scott Addie <[email protected]> * Fix casing Co-authored-by: Scott Addie <[email protected]> * Fix emphasis Co-authored-by: Scott Addie <[email protected]> * Add emphasis Co-authored-by: Scott Addie <[email protected]> * Fix grammar Co-authored-by: Scott Addie <[email protected]> * Make active Co-authored-by: Scott Addie <[email protected]> * Add comma Co-authored-by: Scott Addie <[email protected]> * Fix grammar Co-authored-by: Scott Addie <[email protected]> * Update case Co-authored-by: Scott Addie <[email protected]> * Add missing word Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Fix URL Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Indenting snippets * Various review changes * Update grammar Co-authored-by: Scott Addie <[email protected]> * Change "click" to "select" * Various final edits * Adding deployment article * Linting * Linting * Linting * Linting * Starting to add codeql * Style updates * Initial codeql article * Adding actions v pipelines article * Fix casing on title Co-authored-by: Scott Addie <[email protected]> * Fix casing Co-authored-by: Scott Addie <[email protected]> * Fix casing Co-authored-by: Scott Addie <[email protected]> * Linting * Linting * Linting * Various edits for review * More edits for review process * Casing and spelling updates * Spelling and casing * More edits * edit pass * Edits for review process * More edits for review * Remove bullet * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Another round of edits * Fix click * Edits to grammar * Fix casing * Fix acronym * Grammar edits * More review changes * edit pass * react to build suggestions * fix broken ToC link * Update docs/architecture/devops-for-aspnet-developers/toc.yml Co-authored-by: Sumit Ghosh <[email protected]> Co-authored-by: Beth Massi <[email protected]> Co-authored-by: Scott Addie <[email protected]> Co-authored-by: David Pine <[email protected]> * Devops ebook: Actions index (#23462) * update metadata (#22916) I had added the wrong ms.custom value * update links to ECMA standards (#22942) * update links to ECMA standards ECMA launched an updated website early this year. This PR updates links to ECMA 334 (C#), ECMA 335 (CLI), and TR-84 (XML data formats) * fix build error. Missing opening parenthesis in link. * clarify defensive copies (#22996) Fixes #21691 - Clarify the rules for defensive copies Fixes #22955 - Provide link to conceptual doc with examples. * remove discussion of Task-returning non-async methods (#23001) Fixes #16187 The usage of synchronous Task-returning methods is not generally recommended. See https://github.com/davidfowl/AspNetCoreDiagnosticScenarios/blob/master/AsyncGuidance.md#prefer-asyncawait-over-directly-returning-task The examples were valid, but can cause hard-to-diagnose issues. As we add more advanced async scenarios, this scenario belongs there, with more details about when it is and isn't appropriate. (`using` in the non-async method is the primary mistake to run into). * How to compare strings: correct the list of ordinal-comparison operations (#23007) * fix typo (#23033) `GenEnvVariable` didn't appear in csharp/tutorials/AsyncStreams/start/IssuePRreport/IssuePRreport/Program.cs . so I think it's typo, I'm just getting start in c# and not sure this should be `GetEnvVariable`. Some of issue mention GetEnvVariable and didn't say it's typo , so sorry if it's already correct. Also sorry for my suck English. * Adding hyperlink to reference types (#23038) * Discards article: Fix the section about the discard pattern (#23039) * Discards article: Fix the section about the discard pattern * Update docs/csharp/discards.md Co-authored-by: Bill Wagner <[email protected]> Co-authored-by: Bill Wagner <[email protected]> * fix wrong URL (#23047) [C# Reference] URL is wrong. It's same with [C# Programming Guide] URL as above. * Bump MSTest.TestAdapter (#23053) Bumps [MSTest.TestAdapter](https://github.com/microsoft/testfx) from 2.1.2 to 2.2.1. - [Release notes](https://github.com/microsoft/testfx/releases) - [Commits](https://github.com/microsoft/testfx/compare/v2.1.2...v2.2.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump MSTest.TestFramework (#23051) Bumps [MSTest.TestFramework](https://github.com/microsoft/testfx) from 2.1.2 to 2.2.1. - [Release notes](https://github.com/microsoft/testfx/releases) - [Commits](https://github.com/microsoft/testfx/compare/v2.1.2...v2.2.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump MSTest.TestFramework (#23056) Bumps [MSTest.TestFramework](https://github.com/microsoft/testfx) from 2.1.2 to 2.2.1. - [Release notes](https://github.com/microsoft/testfx/releases) - [Commits](https://github.com/microsoft/testfx/compare/v2.1.2...v2.2.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump MSTest.TestAdapter (#23059) Bumps [MSTest.TestAdapter](https://github.com/microsoft/testfx) from 2.1.2 to 2.2.1. - [Release notes](https://github.com/microsoft/testfx/releases) - [Commits](https://github.com/microsoft/testfx/compare/v2.1.2...v2.2.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump MSTest.TestAdapter (#23061) Bumps [MSTest.TestAdapter](https://github.com/microsoft/testfx) from 2.1.2 to 2.2.1. - [Release notes](https://github.com/microsoft/testfx/releases) - [Commits](https://github.com/microsoft/testfx/compare/v2.1.2...v2.2.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update additional-resources.md (#23077) * Bump MSTest.TestAdapter (#23055) Bumps [MSTest.TestAdapter](https://github.com/microsoft/testfx) from 2.1.2 to 2.2.1. - [Release notes](https://github.com/microsoft/testfx/releases) - [Commits](https://github.com/microsoft/testfx/compare/v2.1.2...v2.2.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump MSTest.TestFramework (#23062) Bumps [MSTest.TestFramework](https://github.com/microsoft/testfx) from 2.1.2 to 2.2.1. - [Release notes](https://github.com/microsoft/testfx/releases) - [Commits](https://github.com/microsoft/testfx/compare/v2.1.2...v2.2.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.CodeAnalysis (#23092) Bumps [Microsoft.CodeAnalysis](https://github.com/dotnet/roslyn) from 3.8.0 to 3.9.0. - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/master/docs/Breaking%20API%20Changes.md) - [Commits](https://github.com/dotnet/roslyn/compare/v3.8.0...v3.9.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.CodeAnalysis.CSharp.Workspaces (#23090) Bumps [Microsoft.CodeAnalysis.CSharp.Workspaces](https://github.com/dotnet/roslyn) from 3.8.0 to 3.9.0. - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/master/docs/Breaking%20API%20Changes.md) - [Commits](https://github.com/dotnet/roslyn/compare/v3.8.0...v3.9.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.CodeAnalysis.CSharp.Workspaces (#23091) Bumps [Microsoft.CodeAnalysis.CSharp.Workspaces](https://github.com/dotnet/roslyn) from 3.8.0 to 3.9.0. - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/master/docs/Breaking%20API%20Changes.md) - [Commits](https://github.com/dotnet/roslyn/compare/v3.8.0...v3.9.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.CodeAnalysis.CSharp.Workspaces (#23087) Bumps [Microsoft.CodeAnalysis.CSharp.Workspaces](https://github.com/dotnet/roslyn) from 3.8.0 to 3.9.0. - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/master/docs/Breaking%20API%20Changes.md) - [Commits](https://github.com/dotnet/roslyn/compare/v3.8.0...v3.9.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix non compilable code (#23095) * Fix non compliable code The sample code doesn't compile. * Update docs/core/diagnostics/distributed-tracing.md Co-authored-by: Youssef Victor <[email protected]> * Apply suggestions from code review Co-authored-by: Youssef Victor <[email protected]> Co-authored-by: Youssef Victor <[email protected]> Co-authored-by: Bill Wagner <[email protected]> * Bump Microsoft.CodeAnalysis.CSharp.Workspaces (#23089) Bumps [Microsoft.CodeAnalysis.CSharp.Workspaces](https://github.com/dotnet/roslyn) from 3.8.0 to 3.9.0. - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/master/docs/Breaking%20API%20Changes.md) - [Commits](https://github.com/dotnet/roslyn/compare/v3.8.0...v3.9.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.CodeAnalysis.CSharp.Workspaces (#23086) Bumps [Microsoft.CodeAnalysis.CSharp.Workspaces](https://github.com/dotnet/roslyn) from 3.8.0 to 3.9.0. - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/master/docs/Breaking%20API%20Changes.md) - [Commits](https://github.com/dotnet/roslyn/compare/v3.8.0...v3.9.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Remove dotnet-trace ps from memory leak tutorial (#23074) * Bump MSTest.TestFramework (#23060) Bumps [MSTest.TestFramework](https://github.com/microsoft/testfx) from 2.1.2 to 2.2.1. - [Release notes](https://github.com/microsoft/testfx/releases) - [Commits](https://github.com/microsoft/testfx/compare/v2.1.2...v2.2.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump coverlet.collector (#22935) Bumps [coverlet.collector](https://github.com/coverlet-coverage/coverlet) from 3.0.2 to 3.0.3. - [Release notes](https://github.com/coverlet-coverage/coverlet/releases) - [Commits](https://github.com/coverlet-coverage/coverlet/commits) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add section about EF Core events in well known events doc (#22828) * Add section about EF Core events in well known events doc * linter error * Update docs/core/diagnostics/well-known-event-providers.md Co-authored-by: John Salem <[email protected]> Co-authored-by: John Salem <[email protected]> * Update download path (#22909) * Update download path * feedback * feedback Co-authored-by: Bill Wagner <[email protected]> * set topic type to reference for WCF diagnostics (#22819) * delete unimplemented rule doc (#22799) * Change EventPipe environment variables that went out of sync (#22947) * Parallel.ForEach should not be used for IO bound tasks (#22957) * Parallel.ForEach with CPU intensive operations * Refactored as per the code review comments * Fix ICorProfilerInfo9 .NET Core version, Fix COR_PRF_REJIT_FLAGS .NET Core version (#22964) * Correct ICorProfilerInfo9 available since .NET Core 2.1 * Correct that COR_PRF_REJIT_FLAGS was available in .NET Core 3.0 (ICorProfilerInfo10) * Cleanup .NET Core 2.2 include * Fix link to CA2247 (#22963) * update VS 'talk to us' link text (#23002) * Fix WF cookbook links (#23018) * Add preview 2 nullability changes (#23019) * Bump Octokit (#22933) Bumps [Octokit](https://github.com/octokit/octokit.net) from 0.49.0 to 0.50.0. - [Release notes](https://github.com/octokit/octokit.net/releases) - [Changelog](https://github.com/octokit/octokit.net/blob/main/ReleaseNotes.md) - [Commits](https://github.com/octokit/octokit.net/compare/v0.49.0...v0.50.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Octokit (#22934) Bumps [Octokit](https://github.com/octokit/octokit.net) from 0.49.0 to 0.50.0. - [Release notes](https://github.com/octokit/octokit.net/releases) - [Changelog](https://github.com/octokit/octokit.net/blob/main/ReleaseNotes.md) - [Commits](https://github.com/octokit/octokit.net/compare/v0.49.0...v0.50.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Require space before DU constructor arguments (#23094) * Bump Microsoft.NET.Test.Sdk (#22973) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](https://github.com/microsoft/vstest/compare/v16.8.3...v16.9.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.NET.Test.Sdk (#22974) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](https://github.com/microsoft/vstest/compare/v16.8.3...v16.9.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.NET.Test.Sdk (#22975) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](https://github.com/microsoft/vstest/compare/v16.8.3...v16.9.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.NET.Test.Sdk in /samples/snippets/csharp/xunit-test (#22976) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](https://github.com/microsoft/vstest/compare/v16.8.3...v16.9.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.NET.Test.Sdk (#22977) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](https://github.com/microsoft/vstest/compare/v16.8.3...v16.9.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.NET.Test.Sdk (#22979) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](https://github.com/microsoft/vstest/compare/v16.8.3...v16.9.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Remove DNX content (#22919) * Add breaking change from 2.0-2.1 (#22917) * breaking change from 2.0-2.1 * Update includes/core-changes/msbuild/2.1/dotnetclitoolreference.md Co-authored-by: Genevieve Warren <[email protected]> * Update includes/core-changes/msbuild/2.1/dotnetclitoolreference.md * Update msbuild file * Update msbuild file date * Update toc/title Co-authored-by: Genevieve Warren <[email protected]> * Bump Microsoft.NET.Test.Sdk (#22980) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](https://github.com/microsoft/vstest/compare/v16.8.3...v16.9.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.NET.Test.Sdk (#22982) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](https://github.com/microsoft/vstest/compare/v16.8.3...v16.9.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.NET.Test.Sdk (#22981) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](https://github.com/microsoft/vstest/compare/v16.8.3...v16.9.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.NET.Test.Sdk (#22984) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](https://github.com/microsoft/vstest/compare/v16.8.3...v16.9.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.NET.Test.Sdk (#22986) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](https://github.com/microsoft/vstest/compare/v16.8.3...v16.9.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Moq (#22978) Bumps [Moq](https://github.com/moq/moq4) from 4.16.0 to 4.16.1. - [Release notes](https://github.com/moq/moq4/releases) - [Changelog](https://github.com/moq/moq4/blob/main/CHANGELOG.md) - [Commits](https://github.com/moq/moq4/compare/v4.16.0...v4.16.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Moq (#22985) Bumps [Moq](https://github.com/moq/moq4) from 4.16.0 to 4.16.1. - [Release notes](https://github.com/moq/moq4/releases) - [Changelog](https://github.com/moq/moq4/blob/main/CHANGELOG.md) - [Commits](https://github.com/moq/moq4/compare/v4.16.0...v4.16.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.NET.Test.Sdk (#22987) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](https://github.com/microsoft/vstest/compare/v16.8.3...v16.9.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add missing prefixes for dotnet tool install (#23042) * Bump Microsoft.NET.Test.Sdk (#22990) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](https://github.com/microsoft/vstest/compare/v16.8.3...v16.9.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.NET.Test.Sdk (#22989) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](https://github.com/microsoft/vstest/compare/v16.8.3...v16.9.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add a note to dotnet nuget add source (#22938) * Explain pseudo-code (#22693) * Fix line numbers for syntax highlighting (#23025) * Fix line numbers for syntax highlighting * Update docs/standard/security/cryptography-model.md * Numeric parsing precision breaking change (#23046) * Added rationale section per #22886 (#22907) * Added rationale section per #22886 * Apply suggestions from code review Co-authored-by: Bill Wagner <[email protected]> * Apply suggestions from code review Co-authored-by: Genevieve Warren <[email protected]> Co-authored-by: Bill Wagner <[email protected]> Co-authored-by: Genevieve Warren <[email protected]> * Add details about "." in env var name (#22915) * Added cross-platform bits for env vars, and note/link re: . in names * Pre-commit hook, applied automatic markdownlint CLI fixes * Apply suggestions from code review * Create version-sweeper workflow YML file (#22931) * Create version-sweep.yml * Update .github/workflows/version-sweep.yml * added link for porting ebook in dotnet arch (#22965) * Porting eBook: add upgrade references (#22930) * add upgrade references * fix trailing spaces * Apply suggestions from code review Co-authored-by: David Pine <[email protected]> Co-authored-by: David Pine <[email protected]> * Explain Dockerfile in detail (#23012) * Address #22941 * Clean up, revery some of the crazy auto formating. * Even more auto format fixes * Fix MD linter violation * Update image syntax, this gives the grey border by default which was missing. * Remove second explaination, as it is a bit redundant. * Initial import of chapter and images * Updating image paths and styling * Update master to main * Remove update of .NET framework after upgrade * Linting updates * Linting updates * Linting update * Update page url in index * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix spelling Co-authored-by: Sumit Ghosh <[email protected]> * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix grammar Co-authored-by: Sumit Ghosh <[email protected]> * Fix spelling Co-authored-by: Sumit Ghosh <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-build.md Co-authored-by: Beth Massi <[email protected]> * Update spelling Co-authored-by: Scott Addie <[email protected]> * Adding comma Co-authored-by: Scott Addie <[email protected]> * Fix casing Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Change click to select Co-authored-by: Scott Addie <[email protected]> * Change click to select Co-authored-by: Scott Addie <[email protected]> * Contractions Co-authored-by: Scott Addie <[email protected]> * Contractions and update of "click" to "select" Co-authored-by: Scott Addie <[email protected]> * Grammar fix Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Fix casing Co-authored-by: Scott Addie <[email protected]> * Fix casing Co-authored-by: Scott Addie <[email protected]> * Fix emphasis Co-authored-by: Scott Addie <[email protected]> * Add emphasis Co-authored-by: Scott Addie <[email protected]> * Fix grammar Co-authored-by: Scott Addie <[email protected]> * Make active Co-authored-by: Scott Addie <[email protected]> * Add comma Co-authored-by: Scott Addie <[email protected]> * Fix grammar Co-authored-by: Scott Addie <[email protected]> * Update case Co-authored-by: Scott Addie <[email protected]> * Add missing word Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Fix URL Co-authored-by: Scott Addie <[email protected]> * Fix spelling Co-authored-by: Scott Addie <[email protected]> * Indenting snippets * Various review changes * Update grammar Co-authored-by: Scott Addie <[email protected]> * Change "click" to "select" * Various final edits * Adding deployment article * Linting * Linting * Linting * Linting * Starting to add codeql * Style updates * Initial codeql article * Adding actions v pipelines article * Adding Actions index page * Fix casing on title Co-authored-by: Scott Addie <[email protected]> * Fix casing Co-authored-by: Scott Addie <[email protected]> * Fix casing Co-authored-by: Scott Addie <[email protected]> * Update markdownlint.yml * Linting * Linting * Linting * Linting * Various edits for review * More edits for review process * Casing and spelling updates * Spelling and casing * Casing updates * More edits * edit pass * Updating main index * Edits for review process * More edits for review * Remove bullet * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Scott Addie <[email protected]> * Another round of edits * Fix click * Edits to grammar * Fix casing * Fix acronym * Grammar edits * More review changes * Adding retain version to URLs * Grammar edits * Grammer fix * Revert "Merge branch 'master' into devops-ebook-actions-index" This reverts commit 4b812a135511a1a0a485f7c2c4c4d4aa20e03448, reversing changes made to 665e0581defb9620002faa4bb26e9b05dfe41d57. * Revert "Grammar edits" This reverts commit d9a33533e80d3504b5b7ff57ea0569f34e017ddf. * Various style edits * edit pass * react to build suggestions * fix broken ToC link * Update docs/architecture/devops-for-aspnet-developers/toc.yml * edit pass Co-authored-by: Bill Wagner <[email protected]> Co-authored-by: Petr Kulikov <[email protected]> Co-authored-by: DeadBushSanpai <[email protected]> Co-authored-by: sampreeth1999 <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Youssef Victor <[email protected]> Co-authored-by: Paulo Morgado <[email protected]> Co-authored-by: Sung Yoon Whang <[email protected]> Co-authored-by: John Salem <[email protected]> Co-authored-by: Maira Wenzel <[email protected]> Co-authored-by: Genevieve Warren <[email protected]> Co-authored-by: Surender Singh <[email protected]> Co-authored-by: Morgan Creekmore <[email protected]> Co-authored-by: Christer van der Meeren <[email protected]> Co-authored-by: Andy De George <[email protected]> Co-authored-by: Tom Dykstra <[email protected]> Co-authored-by: David Pine <[email protected]> Co-authored-by: Sreenivasulu Kalluru <[email protected]> Co-authored-by: Steve Smith <[email protected]> Co-authored-by: Sumit Ghosh <[email protected]> Co-authored-by: Beth Massi <[email protected]> Co-authored-by: Scott Addie <[email protected]> * Edit pass on GitHub Actions eBook content * Adjust the DevOps for ASP.NET Core Developers eBook TOC (#23552) * Update the DevOps for ASP.NET Core devs eBook, TOC * Pre-commit hook, applied automatic markdownlint CLI fixes * Updates based on rendered preview. * Added missing UID * Fix for devops-ebook (#23568) * Included next page link for index page * Fixed previous and next link in each pages * Fixed title for DevOps e-book * Fixed lint error * Updated index page (#23771) * Update docs/architecture/devops-for-aspnet-developers/monitoring.md Co-authored-by: Youssef Victor <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/monitoring.md Co-authored-by: Youssef Victor <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/monitoring.md Co-authored-by: Youssef Victor <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-build.md Co-authored-by: Youssef Victor <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-build.md Co-authored-by: Youssef Victor <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-build.md Co-authored-by: Youssef Victor <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-build.md Co-authored-by: Youssef Victor <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-build.md Co-authored-by: Youssef Victor <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-build.md Co-authored-by: Youssef Victor <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-build.md Co-authored-by: Youssef Victor <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-build.md Co-authored-by: Youssef Victor <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-codeql.md Co-authored-by: Youssef Victor <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-deploy.md Co-authored-by: Youssef Victor <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-deploy.md Co-authored-by: Youssef Victor <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-vs-pipelines.md Co-authored-by: Youssef Victor <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-vs-pipelines.md Co-authored-by: Youssef Victor <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-vs-pipelines.md Co-authored-by: Youssef Victor <[email protected]> * Included review suggestions * Fixed lint errors * Included further suggestions * Removed unncessary codefence * Apply suggestions from code review Co-authored-by: David Pine <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-deploy.md Co-authored-by: David Pine <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-deploy.md Co-authored-by: David Pine <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-deploy.md Co-authored-by: David Pine <[email protected]> * Update docs/architecture/devops-for-aspnet-developers/actions-deploy.md Co-authored-by: David Pine <[email protected]> * Changed default branch from master to main * Updated cicd content * Fixed build related warning * Fixed indentation * Apply suggestions from code review * Apply suggestions from code review Fix broken links and add preserve view query string parameter. Co-authored-by: Nish Anil <[email protected]> Co-authored-by: Colin Dembovsky <[email protected]> Co-authored-by: Beth Massi <[email protected]> Co-authored-by: Scott Addie <[email protected]> Co-authored-by: David Pine <[email protected]> Co-authored-by: Bill Wagner <[email protected]> Co-authored-by: Petr Kulikov <[email protected]> Co-authored-by: DeadBushSanpai <[email protected]> Co-authored-by: sampreeth1999 <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Youssef Victor <[email protected]> Co-authored-by: Paulo Morgado <[email protected]> Co-authored-by: Sung Yoon Whang <[email protected]> Co-authored-by: John Salem <[email protected]> Co-authored-by: Maira Wenzel <[email protected]> Co-authored-by: Genevieve Warren <[email protected]> Co-authored-by: Surender Singh <[email protected]> Co-authored-by: Morgan Creekmore <[email protected]> Co-authored-by: Christer van der Meeren <[email protected]> Co-authored-by: Andy De George <[email protected]> Co-authored-by: Tom Dykstra <[email protected]> Co-authored-by: Sreenivasulu Kalluru <[email protected]> Co-authored-by: Steve Smith <[email protected]> Co-authored-by: Scott Addie <[email protected]>
The last code block in this docs article either throws an exception or directly returns a
Task
without awaiting it. This is directly contradictory to what David Fowler and Stephen Cleary suggest. See also this issue regarding David Fowler's advice: davidfowl/AspNetCoreDiagnosticScenarios#53Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
The text was updated successfully, but these errors were encountered: