Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New File - print-text-doc #1360

Merged
merged 17 commits into from
May 4, 2022

Conversation

rachana-satao
Copy link
Contributor

No description provided.

@rachana-satao rachana-satao marked this pull request as draft April 19, 2022 11:48
@rachana-satao rachana-satao marked this pull request as ready for review April 28, 2022 10:51
Copy link
Contributor

@adegeo adegeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading through the document, it seems a bit out of order. I would do the steps like so:

  1. Add the print document component
  2. Add a string variable to the class
  3. Create the code to load the document and start the printing, such as with a button click. Highlight and mention the .Print() method raises the event.
  4. Create the PrintPage event handler
  5. Show the code for the PrintPage event handler

Copy link
Contributor

@adegeo adegeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some more suggestions. If you use the Files changed tab here in github, you can use the Add suggestion to batch to accept multiple suggestions as a single commit. Then you can easily see the commit diff between the two versions of the file. Feel free to push back and comment on anything that you thing can be further improved or if you don't agree with my suggestions.

Thanks!!

rachana-satao and others added 2 commits May 4, 2022 10:33
@adegeo adegeo enabled auto-merge (squash) May 4, 2022 16:14
@adegeo adegeo merged commit be323ed into dotnet:main May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants