-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New File - print-text-doc #1360
New File - print-text-doc #1360
Conversation
…S-1888233-print-text-doc-2
dotnet-desktop-guide/net/winforms/printing/how-to-print-text-document.md
Outdated
Show resolved
Hide resolved
dotnet-desktop-guide/net/winforms/printing/how-to-print-text-document.md
Outdated
Show resolved
Hide resolved
dotnet-desktop-guide/net/winforms/printing/how-to-print-text-document.md
Outdated
Show resolved
Hide resolved
dotnet-desktop-guide/net/winforms/printing/how-to-print-text-document.md
Outdated
Show resolved
Hide resolved
dotnet-desktop-guide/net/winforms/printing/how-to-print-text-document.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading through the document, it seems a bit out of order. I would do the steps like so:
- Add the print document component
- Add a string variable to the class
- Create the code to load the document and start the printing, such as with a button click. Highlight and mention the
.Print()
method raises the event. - Create the
PrintPage
event handler - Show the code for the
PrintPage
event handler
dotnet-desktop-guide/net/winforms/printing/how-to-print-text-document.md
Show resolved
Hide resolved
dotnet-desktop-guide/net/winforms/printing/snippets/how-to-print-text-document/csharp/Form1.cs
Outdated
Show resolved
Hide resolved
dotnet-desktop-guide/net/winforms/printing/snippets/how-to-print-text-document/csharp/Form1.cs
Outdated
Show resolved
Hide resolved
dotnet-desktop-guide/net/winforms/printing/how-to-print-text-document.md
Outdated
Show resolved
Hide resolved
dotnet-desktop-guide/net/winforms/printing/how-to-print-text-document.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some more suggestions. If you use the Files changed
tab here in github, you can use the Add suggestion to batch
to accept multiple suggestions as a single commit. Then you can easily see the commit diff between the two versions of the file. Feel free to push back and comment on anything that you thing can be further improved or if you don't agree with my suggestions.
Thanks!!
dotnet-desktop-guide/net/winforms/printing/how-to-print-text-document.md
Outdated
Show resolved
Hide resolved
dotnet-desktop-guide/net/winforms/printing/how-to-print-text-document.md
Outdated
Show resolved
Hide resolved
dotnet-desktop-guide/net/winforms/printing/snippets/how-to-print-text-document/csharp/Form1.cs
Outdated
Show resolved
Hide resolved
dotnet-desktop-guide/net/winforms/printing/snippets/how-to-print-text-document/vb/Form1.vb
Outdated
Show resolved
Hide resolved
dotnet-desktop-guide/net/winforms/printing/how-to-print-text-document.md
Outdated
Show resolved
Hide resolved
dotnet-desktop-guide/net/winforms/printing/how-to-print-text-document.md
Outdated
Show resolved
Hide resolved
dotnet-desktop-guide/net/winforms/printing/how-to-print-text-document.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Andy (Steve) De George <[email protected]>
No description provided.