-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add fail-fast logics when --serve
option enabled & port is already used
#9690
chore: Add fail-fast logics when --serve
option enabled & port is already used
#9690
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9690 +/- ##
==========================================
- Coverage 74.31% 74.25% -0.07%
==========================================
Files 536 536
Lines 23189 23214 +25
Branches 4056 4064 +8
==========================================
+ Hits 17234 17237 +3
- Misses 4853 4874 +21
- Partials 1102 1103 +1 ☔ View full report in Codecov by Sentry. |
Personally, I prefer the `fail-fast approach' to the proposed approach.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @filzrev !
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [docfx](https://github.com/dotnet/docfx) | `2.75.2` -> `2.75.3` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/docfx/2.75.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/docfx/2.75.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/docfx/2.75.2/2.75.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/docfx/2.75.2/2.75.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>dotnet/docfx (docfx)</summary> ### [`v2.75.3`](https://github.com/dotnet/docfx/releases/tag/v2.75.3) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### 🐞 Bug Fixes - fix: Toc warnings when toc item with TopicUid but name is not specified by [@​filzrev](https://github.com/filzrev) in [https://github.com/dotnet/docfx/pull/9665](https://github.com/dotnet/docfx/pull/9665) - fix: Warnings that occurs when bookmark link contains non-ASCII chars by [@​filzrev](https://github.com/filzrev) in [https://github.com/dotnet/docfx/pull/9660](https://github.com/dotnet/docfx/pull/9660) - fix: Add StackTrace logs for Javascript error by [@​filzrev](https://github.com/filzrev) in [https://github.com/dotnet/docfx/pull/9694](https://github.com/dotnet/docfx/pull/9694) - fix: InvalidInputFile error occurs if file contains URI escaped charactors by [@​filzrev](https://github.com/filzrev) in [https://github.com/dotnet/docfx/pull/9700](https://github.com/dotnet/docfx/pull/9700) - fix: Add fail-fast logics when `--serve` option enabled & port is already used by [@​filzrev](https://github.com/filzrev) in [https://github.com/dotnet/docfx/pull/9690](https://github.com/dotnet/docfx/pull/9690) - fix: filterconfig exclude rule is not works as documented by [@​filzrev](https://github.com/filzrev) in [https://github.com/dotnet/docfx/pull/9666](https://github.com/dotnet/docfx/pull/9666) ##### 🔧 Engineering - build(deps): bump YamlDotNet from 15.1.0 to 15.1.1 dependencies .NET by [@​filzrev](https://github.com/filzrev) in [https://github.com/dotnet/docfx/pull/9689](https://github.com/dotnet/docfx/pull/9689) - chore: update NuGet package dependencies (Microsoft.NET.Test.Sdk,Microsoft.Build.Locator) by [@​filzrev](https://github.com/filzrev) in [https://github.com/dotnet/docfx/pull/9693](https://github.com/dotnet/docfx/pull/9693) - chore: Update public API snapshot & disable `AutoVerify` on CI build by [@​filzrev](https://github.com/filzrev) in [https://github.com/dotnet/docfx/pull/9692](https://github.com/dotnet/docfx/pull/9692) - chore: Update node.js version by [@​filzrev](https://github.com/filzrev) in [https://github.com/dotnet/docfx/pull/9701](https://github.com/dotnet/docfx/pull/9701) - chore: Update Microsoft.Build package version by [@​filzrev](https://github.com/filzrev) in [https://github.com/dotnet/docfx/pull/9698](https://github.com/dotnet/docfx/pull/9698) **Full Changelog**: dotnet/docfx@v2.75.2...v2.75.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9pm,before 6am" in timezone Europe/Zurich, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/buehler/dotnet-operator-sdk). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOTEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE5MS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…lready used (dotnet#9690) chore: Add fail-fast logics when port is already used on serve
What included in this PR
Add fail-fast logics when
--serve
option enabled and specified TCP port is already used.Background
docfx build
commands takes some times to complete.When combined with
--serve
options.Command fails on
RunServe::Exec
phase.And need to run the `docfx serve' command separately.
This PR add TCP port availability check before start
metadata
/build
commands.And fail-fast if port is already used.
Test
I've manually confirmed behaviors with following
--hostname
patternsnull
/localhost
127.0.0.1
and::1
)*
127.0.0.1
/127.0.0.2
)