Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Verify.Xunit dependencies #9624

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented Jan 18, 2024

What's included in this PR

  • Update Verify.Xunit NuGet package version
  • Update xunit Nuget package version
  • Add dependabot grouping configuration for xUnit.

Background
This PR intended to supersede #9620.
Verify.Xunit package seems requireing latest version of xunit packages as minimum requirement.
So I've added dependabot grouping configuration for xunit related packages also.

@filzrev
Copy link
Contributor Author

filzrev commented Jan 18, 2024

I've removed [UsesVerify] attributes.
Because it's redundant after Verify.Xunit updated. (See: VerifyTests/Verify#1131)

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2c5f8ea) 74.32% compared to head (93069f0) 74.32%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9624   +/-   ##
=======================================
  Coverage   74.32%   74.32%           
=======================================
  Files         536      536           
  Lines       23169    23169           
  Branches     4053     4053           
=======================================
  Hits        17220    17220           
  Misses       4848     4848           
  Partials     1101     1101           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you @filzrev !

@yufeih yufeih merged commit d79836f into dotnet:main Jan 18, 2024
8 checks passed
@yufeih yufeih added the engineering Makes the pull request to appear in the "Engineering" section of the next release note label Jan 18, 2024
@filzrev filzrev deleted the chore-update-xunit-dependencies branch April 1, 2024 05:03
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Makes the pull request to appear in the "Engineering" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants