Added extensions configuration point and PlantUml support #9574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjlotz
changed the title
|
@dotnet-policy-service agree |
yufeih
added
the
new-feature
|
@dotnet-policy-service agree |
yufeih
reviewed
Jan 2, 2024
src/Docfx.MarkdigEngine.Extensions/PlantUml/FormatterFactory.cs
Outdated
Show resolved
Hide resolved
yufeih
reviewed
Jan 2, 2024
test/Docfx.MarkdigEngine.Extensions.Tests/QuoteSectionNoteTest.cs
Outdated
Show resolved
Hide resolved
@yufeih Glad to assist. I will be away on some leave soon, so let me know if there is anything left to do to enable you to merge the pull request. Looking forward to using the latest version of docfx with this included. |
filzrev
reviewed
Jan 3, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9574 +/- ##
==========================================
- Coverage 74.35% 74.33% -0.02%
==========================================
Files 534 536 +2
Lines 23099 23175 +76
Branches 4044 4057 +13
==========================================
+ Hits 17175 17227 +52
- Misses 4825 4841 +16
- Partials 1099 1107 +8 ☔ View full report in Codecov by Sentry. |
p-kostov
pushed a commit
to ErpNetDocs/docfx
that referenced
this pull request
Jun 28, 2024
…et#9574) * Added extensions configuration point and PlantUmlExtension * Address review comments and improve error handling of PlantUmlExtension * Remove output formatters * Update JsonConverterTest.cs to ignoreLineEndingDifferences * Update JsonConverterTest.cs --------- Co-authored-by: Yufei Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #9566 , this pull request aims to add support for rendering PlantUml diagrams using the latest docfx toolchain. This will unblock all existing users who want to continue using docfx and PlantUml.
This comment covers the approach taken to implement the
PlantUmlExtension. Some basic tests were added for the extension points touched. As mentioned some tests in theQuoteSectionNoteTestare failing which seems to be related to CR-LF return issues which I am unable to resolve. Help for getting this resolved will be much appreciated.fixes #2347 fixes #8763 fixes #9566