Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): bump typescript from 5.3.2 to 5.3.3 in /templates #9512

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 7, 2023

Bumps typescript from 5.3.2 to 5.3.3.

Release notes

Sourced from typescript's releases.

TypeScript 5.3.3

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps [typescript](https://github.com/Microsoft/TypeScript) from 5.3.2 to 5.3.3.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v5.3.2...v5.3.3)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Dec 7, 2023
@github-actions github-actions bot enabled auto-merge (squash) December 7, 2023 07:13
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0bebd86) 71.34% compared to head (249b1c5) 71.34%.
Report is 8 commits behind head on main.

❗ Current head 249b1c5 differs from pull request most recent head 7a32916. Consider uploading reports for the commit 7a32916 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9512   +/-   ##
=======================================
  Coverage   71.34%   71.34%           
=======================================
  Files         558      558           
  Lines       24048    24048           
  Branches     4182     4182           
=======================================
  Hits        17156    17156           
  Misses       5793     5793           
  Partials     1099     1099           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -214,6 +214,7 @@
"topicHref": "BuildFromProject.Inheritdoc.Issue6366.Class1-1.html",
"topicUid": "BuildFromProject.Inheritdoc.Issue6366.Class1`1",
"name.vb": "Inheritdoc.Issue6366.Class1(Of T)",
"name.": null,
Copy link
Contributor

@filzrev filzrev Dec 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know that is related to diffs problems thought.
CI log indicating docfx metadata processing and dotnet serve commands seems to be executed in parallel.
(And ConsoleLogger is registered twice)

2023-12-07T07:16:41.1373589Z Serving "/home/runner/work/docfx/docfx/samples/seed/_site" on http://localhost:8089. Press Ctrl+C to shut down.
2023-12-07T07:17:04.3573864Z �[38;5;15mLoading solution /home/runner/work/docfx/docfx/samples/seed/dotnet/solution/BuildFromSolution.sln�[0m
2023-12-07T07:17:04.3575573Z �[38;5;15mLoading solution /home/runner/work/docfx/docfx/samples/seed/dotnet/solution/BuildFromSolution.sln�[0m
2023-12-07T07:17:04.3652332Z �[38;5;15mLoading project /home/runner/work/docfx/docfx/samples/seed/dotnet/solution/CatLibrary/CatLibrary.csproj�[0m
2023-12-07T07:17:04.3654210Z �[38;5;15mLoading project /home/runner/work/docfx/docfx/samples/seed/dotnet/solution/CatLibrary/CatLibrary.csproj�[0m

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've compared CI log that are successfully completed without diff.
But log output seems same.
So above comment is not related to diff problems.

@yufeih yufeih closed this Dec 13, 2023
auto-merge was automatically disabled December 13, 2023 14:31

Pull request was closed

Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 13, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@yufeih yufeih reopened this Dec 13, 2023
@yufeih yufeih merged commit fb7ebc6 into main Dec 13, 2023
1 check passed
@yufeih yufeih deleted the dependabot/npm_and_yarn/templates/main/typescript-5.3.3 branch December 13, 2023 14:42
@yufeih
Copy link
Contributor

yufeih commented Dec 13, 2023

We can probably drop support of NameInDevLangs for TOC, it was intended to let dynamic language switching between C#/VB/F#/C++ also affecting TOC nodes but was never really fully implemented due to complexity even on MS learn.

p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
…otnet#9512)

* build(deps-dev): bump typescript from 5.3.2 to 5.3.3 in /templates

Bumps [typescript](https://github.com/Microsoft/TypeScript) from 5.3.2 to 5.3.3.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v5.3.2...v5.3.3)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* test(snapshot): update snapshots 4036132 for ubuntu-latest

* test(snapshot): update snapshots e9021b8 for ubuntu-latest

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: yufeih <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants