-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Change output html file encoding to UTF-8 (No BOM) #9131
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #9131 +/- ##
=======================================
Coverage 77.58% 77.58%
=======================================
Files 591 591
Lines 24567 24568 +1
=======================================
+ Hits 19060 19061 +1
Misses 5507 5507
☔ View full report in Codecov by Sentry. |
What's the meta tag? I don't see it in the description. |
Sorry it indicate default template modern template |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
chore: change output html file encoding to UTF-8 (No BOM)
…tnet#9131)" This reverts commit 505f7cf. Fixes dotnet#9171
What's included in this PR
Background
Currently docfx output HTML files using UTF-8 (with BOM) encoding.
And other non-HTML files are using UTF-8 (No BOM).
Currently docfx output HTML with following meta tag. so it seems BOM is not required.
If there is any reason to use
UTF-8(BOM)
close this PR.(For example. Snapshot tests library requires BOM)