Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add code coverage excusions #9102

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented Aug 18, 2023

What included in this PR
Add ExcludeFromCodeCoverage attribute that randomly cause CodeCov coverage indirect diff. (See #9067)

I don't know what cause detached branch state (Checkout by commitId in some condition?)
But I though it's safe to exclude from code coverage.

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02% 🎉

Comparison is base (f698eac) 77.57% compared to head (bea5f14) 77.60%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9102      +/-   ##
==========================================
+ Coverage   77.57%   77.60%   +0.02%     
==========================================
  Files         592      592              
  Lines       24608    24590      -18     
==========================================
- Hits        19090    19082       -8     
+ Misses       5518     5508      -10     
Files Changed Coverage Δ
src/Docfx.Common/Git/GitUtility.cs 85.54% <ø> (+3.87%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you @filzrev

@yufeih yufeih added the engineering Makes the pull request to appear in the "Engineering" section of the next release note label Aug 19, 2023
@yufeih yufeih merged commit 46f43bc into dotnet:main Aug 19, 2023
@filzrev filzrev deleted the chore-add-codecoverage-exclusion branch August 24, 2023 02:46
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
chore: add code coverage excusions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Makes the pull request to appear in the "Engineering" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants