Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: disable cert revoke list check using env variable DOCFX_NO_CHECK_CERTIFICATE_REVOCATION_LIST #9017

Merged
merged 1 commit into from
Jul 27, 2023
Merged

feat: disable cert revoke list check using env variable DOCFX_NO_CHECK_CERTIFICATE_REVOCATION_LIST #9017

merged 1 commit into from
Jul 27, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Jul 27, 2023

fixes #9005

@yufeih yufeih added the new-feature Makes the pull request to appear in "New Features" section of the next release note label Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.11% 🎉

Comparison is base (bed685d) 76.76% compared to head (d1d13c4) 76.88%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9017      +/-   ##
==========================================
+ Coverage   76.76%   76.88%   +0.11%     
==========================================
  Files         592      591       -1     
  Lines       24795    24758      -37     
==========================================
+ Hits        19034    19035       +1     
+ Misses       5761     5723      -38
Files Changed Coverage Δ
...c/Docfx.Build.Engine/XRefMaps/XRefMapDownloader.cs 83.95% <100.00%> (+0.83%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yufeih yufeih merged commit dd59353 into main Jul 27, 2023
@yufeih yufeih deleted the no-cert-check branch July 27, 2023 04:12
@chenrui333 chenrui333 mentioned this pull request Aug 21, 2023
Merged
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
@yufeih @p-kostov
feat: disable cert revoke list check using env variable DOCFX_NO_CHEC…
5fb02eb 
…K_CERTIFICATE_REVOCATION_LIST (dotnet#9017)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new-feature Makes the pull request to appear in "New Features" section of the next release note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] CheckCertificateRevocationList should be configurable
1 participant
@yufeih