-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Node.js and package dependencies #9009
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #9009 +/- ##
=======================================
Coverage 76.75% 76.76%
=======================================
Files 592 592
Lines 24795 24795
=======================================
+ Hits 19032 19033 +1
+ Misses 5763 5762 -1 ☔ View full report in Codecov by Sentry. |
It seems following error are randomly occurs on snapshot test. (For example: #9008)
As far as I've comparing succeed log and error log.
So I've added simple Note: It may be better to replace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
This PR contains following changes
1. Update CI workflow Node.js version to 18
Update Node.js version used by CI to 18(Current LTS version)
Because Node.js 16 supports ends by September 11th, 2023.
https://nodejs.org/gl/blog/announcements/nodejs16-eol
2. Update
semver
version to6.2.1
Currently following vulnerability warnings occurred when running
npm install
command.(And it seems dependabot don't create PR for this vulnerability?)
3. Update
typescript-eslint
and related package from5.6.x
to6.2.0
Manually update these package versions.
Because created PR by
dependabot
seems always failed to update these package versions to6,x
.4. jQuery package update
It's is explicitly configured to ignored by dependabot.
https://github.com/dotnet/docfx/blob/main/.github/dependabot.yml#L13-L16
I've updated version manually.
3.6.2
->3.7.0
)