Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js and package dependencies #9009

Merged
merged 6 commits into from
Jul 26, 2023

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented Jul 25, 2023

This PR contains following changes

1. Update CI workflow Node.js version to 18

Update Node.js version used by CI to 18(Current LTS version)
Because Node.js 16 supports ends by September 11th, 2023.
https://nodejs.org/gl/blog/announcements/nodejs16-eol

2. Update semver version to 6.2.1

Currently following vulnerability warnings occurred when running npm install command.
(And it seems dependabot don't create PR for this vulnerability?)

1 moderate severity vulnerability
To address all issues, run:
npm audit fix

3. Update typescript-eslint and related package from 5.6.x to 6.2.0

Manually update these package versions.
Because created PR by dependabot seems always failed to update these package versions to 6,x.

4. jQuery package update

It's is explicitly configured to ignored by dependabot.
https://github.com/dotnet/docfx/blob/main/.github/dependabot.yml#L13-L16

I've updated version manually.

  • jquery (3.6.2 -> 3.7.0)

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (78b4679) 76.75% compared to head (bc91c87) 76.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9009   +/-   ##
=======================================
  Coverage   76.75%   76.76%           
=======================================
  Files         592      592           
  Lines       24795    24795           
=======================================
+ Hits        19032    19033    +1     
+ Misses       5763     5762    -1     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@filzrev
Copy link
Contributor Author

filzrev commented Jul 25, 2023

It seems following error are randomly occurs on snapshot test. (For example: #9008)

Microsoft.Playwright.PlaywrightException : net::ERR_CONNECTION_REFUSED at http://localhost:8089/index.html

As far as I've comparing succeed log and error log.
Test [FAIL] log occurred nearly same time as webserver startup log.
And it seems Playwright don't wait webserver startup and don't retry automatically.

2023-07-25T13:19:33.7125462Z Serving "/home/runner/work/docfx/docfx/samples/seed/_site" on http://localhost:8089. Press Ctrl+C to shut down.
2023-07-25T13:19:34.1960436Z [xUnit.net 00:00:54.40]     Docfx.Tests.SamplesTest.SeedHtml [FAIL]
2023-07-25T13:19:34.3101141Z   Failed Docfx.Tests.SamplesTest.SeedHtml [12 s]
2023-07-25T13:19:34.3101734Z   Error Message:
2023-07-25T13:19:34.3102357Z    Microsoft.Playwright.PlaywrightException : net::ERR_CONNECTION_REFUSED at http://localhost:8089/index.html

So I've added simple SpinWait to check active port.
Then it seems successfully working.

Note: It may be better to replace SpinWait based TCP port check to something like Microsoft.Extensions.Primitives.IChangeToken based notifications later. (and add support ICancellationToken)

Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@yufeih yufeih merged commit bb7d7ec into dotnet:main Jul 26, 2023
@yufeih yufeih added the engineering Makes the pull request to appear in the "Engineering" section of the next release note label Jul 26, 2023
@filzrev filzrev deleted the update-nodejs-and-dependencies branch July 26, 2023 01:43
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Makes the pull request to appear in the "Engineering" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants