Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: optimize default plugin load speed #8810

Merged
merged 1 commit into from
May 30, 2023
Merged

perf: optimize default plugin load speed #8810

merged 1 commit into from
May 30, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented May 30, 2023

Skip assemblies that don't reference Microsoft.DocAsCode.Plugins. Reduces default plugin assembly load time from ~500ms to 60ms.

#8740

@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch coverage: 76.92% and project coverage change: +0.01 🎉

Comparison is base (194e503) 76.94% compared to head (586c7b1) 76.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8810      +/-   ##
==========================================
+ Coverage   76.94%   76.95%   +0.01%     
==========================================
  Files         607      607              
  Lines       25058    25069      +11     
==========================================
+ Hits        19280    19291      +11     
  Misses       5778     5778              
Impacted Files Coverage Δ
...ft.DocAsCode.App/Helpers/DocumentBuilderWrapper.cs 72.97% <76.92%> (+1.13%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yufeih yufeih merged commit a902f31 into main May 30, 2023
@yufeih yufeih deleted the optimize-plugin-load branch May 30, 2023 04:27
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant