Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add _appLogoUrl metadata #8737

Merged
merged 2 commits into from
May 6, 2023
Merged

feat: add _appLogoUrl metadata #8737

merged 2 commits into from
May 6, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented May 6, 2023

fixes #8736

@yufeih yufeih added the new-feature Makes the pull request to appear in "New Features" section of the next release note label May 6, 2023
@yufeih yufeih closed this May 6, 2023
@yufeih yufeih reopened this May 6, 2023
@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Patch coverage: 90.00% and project coverage change: +0.04 🎉

Comparison is base (2fe10f3) 76.91% compared to head (7c8e5c0) 76.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8737      +/-   ##
==========================================
+ Coverage   76.91%   76.96%   +0.04%     
==========================================
  Files         606      606              
  Lines       25065    25062       -3     
==========================================
+ Hits        19278    19288      +10     
+ Misses       5787     5774      -13     
Impacted Files Coverage Δ
...ft.DocAsCode.App/Helpers/DocumentBuilderWrapper.cs 71.83% <0.00%> (ø)
...ft.DocAsCode.MarkdigEngine.Extensions/Constants.cs 100.00% <ø> (ø)
src/docfx/Models/BuildCommand.cs 45.45% <0.00%> (+7.71%) ⬆️
....DocAsCode.MarkdigEngine/MarkdigMarkdownService.cs 87.36% <75.00%> (-0.52%) ⬇️
...ions/QuoteSectionNote/QuoteSectionNoteExtension.cs 81.81% <81.25%> (ø)
...ine/ResourceFileReaders/CompositeResourceReader.cs 88.88% <90.90%> (-6.95%) ⬇️
.../Microsoft.DocAsCode.App/Config/BuildJsonConfig.cs 86.11% <100.00%> (ø)
...oft.DocAsCode.Build.Engine/DocumentBuildContext.cs 66.66% <100.00%> (+0.54%) ⬆️
....DocAsCode.Build.Engine/DocumentBuildParameters.cs 100.00% <100.00%> (ø)
...Build.Engine/TemplateProcessors/TemplateManager.cs 88.63% <100.00%> (-0.26%) ⬇️
... and 5 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yufeih yufeih merged commit 0777483 into main May 6, 2023
@yufeih yufeih deleted the applogourl branch May 6, 2023 02:19
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
* feat: add _appLogoUrl metadata

* test(snapshot): update snapshots for 67061b4

---------

Co-authored-by: yufeih <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature Makes the pull request to appear in "New Features" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Allow URL for homepage (logo image) link to be specified in docfx.json
1 participant