Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add modern template customization options #8682

Merged
merged 3 commits into from
Apr 28, 2023
Merged

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Apr 25, 2023

Enables these modern template customization options through a new public/main.js file:

  • default theme
  • icons next to the theme picker
  • anchors
  • mermaid diagrams
  • syntax highlighting using highlight.js

BREAKING CHANGE: styles in modern templates are renamed to public to house scripts and styles to be published to the static sites.

fixes #8677 #8652 #8655

@yufeih yufeih added the new-feature Makes the pull request to appear in "New Features" section of the next release note label Apr 25, 2023
@yufeih yufeih force-pushed the ts-extensibility branch from 95e801f to 84c5a03 Compare April 25, 2023 08:08
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (5532bf2) 76.92% compared to head (3d3b518) 76.91%.

❗ Current head 3d3b518 differs from pull request most recent head f5f999b. Consider uploading reports for the commit f5f999b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8682      +/-   ##
==========================================
- Coverage   76.92%   76.91%   -0.01%     
==========================================
  Files         606      606              
  Lines       25062    25062              
==========================================
- Hits        19278    19277       -1     
- Misses       5784     5785       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yufeih yufeih closed this Apr 25, 2023
@yufeih yufeih reopened this Apr 25, 2023
@yufeih yufeih force-pushed the ts-extensibility branch 2 times, most recently from b4c28da to 63a123b Compare April 27, 2023 07:00
@yufeih yufeih closed this Apr 27, 2023
@yufeih yufeih reopened this Apr 27, 2023
@yufeih yufeih force-pushed the ts-extensibility branch from 7f8d44a to 3d3b518 Compare April 28, 2023 15:05
@yufeih yufeih closed this Apr 28, 2023
@yufeih yufeih reopened this Apr 28, 2023
@yufeih yufeih merged commit 7b699c9 into main Apr 28, 2023
@yufeih yufeih deleted the ts-extensibility branch April 28, 2023 15:23
@yufeih yufeih added breaking-change Makes the pull request appear in "Breaking Changes" section of the next release note and removed breaking-change Makes the pull request appear in "Breaking Changes" section of the next release note labels May 5, 2023
@KalleOlaviNiemitalo
Copy link

Note, the breaking change also applies to custom themes, not only custom templates.

@niltor
Copy link

niltor commented May 8, 2023

Is there example codes for main.js?

@yufeih
Copy link
Contributor Author

yufeih commented May 8, 2023

p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature Makes the pull request to appear in "New Features" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support syntax highlight for Bicep language
3 participants