Enable roslyn analyzers #1044
Enable roslyn analyzers #1044
Conversation
|
Hello @hoyosjs! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 1 minute. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
@msftbot merge after @josalem reviews |
ghost
added
the
|
Hello @hoyosjs! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
|
Is the expectation that we will merge this on red and follow up to fix the warnings that are causing the failed jobs in CI? |
The merge doesn't happen on red CI. I didn't commit one of the files to add an exception for a false positive. |
ghost
merged commit 
…ests on Android (#64358) * [tests][eventpipe] Port over Dotnet/Diagnostics files for mobile eventpipe tests Copied over files from src/Microsoft.Diagnostics.NETCore.Client based off of 99fab307 * [tests][eventpipe] Add TCP/IP logic for mobile eventpipe tests * [tests] Remove Microsoft.Diagnostics.NETCore.Client package reference * [tests][eventpipe] Downstream Diagnostics IpcTraceTest DiagnosticsClient bootstrap dotnet/diagnostics#720 * [tests][eventpipe] Downstream Diagnostics roslyn analyzer IpcTraceTest change dotnet/diagnostics#1044 * [tests][eventpipe] Enable TCPIP DiagnosticsClient in IpcTraceTest for Android * [tests][eventpipe] Aesthetic IpcTraceTest modifications * [tests][eventpipe] Disable subprocesses tests on Android * [tests][eventpipe] Update processinfo * [tests][eventpipe] Update processinfo2 * [tests][eventpipe] Update eventsourceerror * [tests][eventpipe] Update bigevent * [tests][eventpipe] Update buffersize * [tests][eventpipe] Update rundownvalidation * [tests][eventpipe] Update providervalidation * [tests][eventpipe] Update gcdump * [tests][JIT] Update debuginfo/tester * [tests] Segment Microsoft.Diagnostics.NETCore.Client relevant tests for Linux arm coreclr * Account for nonspecified RuntimeFlavor * [tests] Moveup Default coreclr RuntimeFlavor property explicit declaration * [tests] Duplicate Microsoft.Diagnostics.NETCore.Client dependent tests for Linux arm * Fix debuginfo/tester test skip * Temporarily enable bigevent on Linux arm and remove duplicate exclude * Fix unaligned UTF16 string read in collect tracing EventPipe command. Collect tracing 2 EventPipe command triggers an unaligned UTF16 string read that could cause a SIGBUS on platforms not supporting unalinged reads of UTF16 strings (so far only seen on 32-bit ARM Linux CI machine). On CoreCLR this could even cause a unalinged int read due to optimizations used in UTF8Encoding::GetByteCount. * Revert "[tests] Duplicate Microsoft.Diagnostics.NETCore.Client dependent tests for Linux arm" This reverts commit cb2cacd. * Revert "[tests] Segment Microsoft.Diagnostics.NETCore.Client relevant tests for Linux arm coreclr" This reverts commit dc29676. * Revert "Fix debuginfo/tester test skip" This reverts commit 1e90d7e. Co-authored-by: Mitchell Hwang <[email protected]> Co-authored-by: lateralusX <[email protected]>
Add roslyn analyzers and corresponding rules to ensure compliance with compliance and fix basic errors spotted by first round of analyzers.