-
Notifications
You must be signed in to change notification settings - Fork 4.9k
System.Net.Security test stabilization #7937
Conversation
Unix tests failed as I forgot to change the test unix/project.json file. |
The OSX package restore failed, potentially caused by #7902:
|
@dotnet-bot Test Innerloop OSX Debug Build and Test |
LGTM |
@@ -36,7 +36,24 @@ public void ReadFrame(bool server, out byte[] buffer) | |||
|
|||
semaphore.Wait(WaitForReadDataTimeoutMilliseconds); | |||
|
|||
bool dequeueSucceeded = packetQueue.TryDequeue(out buffer); | |||
bool dequeueSucceeded = false; | |||
int remainingRetries = 3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: since this appears to be the total number of tries rather than retries, maybe remainingTries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing.
Overnight test results. One test failed:
/cc @davidsh This particular test is the only one having a dependency on Azure. What we might have seen was either downtime or automatic DoS countermeasure implemented on the remote server. Tracking with #3697. |
Same failures on both OSX boxes (#7902). |
No failures on both the VMs so far with the current configuration. |
74ce7de
to
b41e0f1
Compare
@stephentoub No-go: tests failed within the first minute of 100 parallel executions on my 12 CPU machine. It appears that the tests do run longer than 10s for the first time if a lot of processes are created. After a while they enter a steady-state where tests run fast (7-8s). I've changed the timeout to 1 minute to avoid the timeouts in CI. |
Overnight tests failed the same way: |
Several System.Net.Security test fixes.
Ubuntu test failed because of #7234 |
Test Innerloop Ubuntu14.04 Debug Build and Test please |
System.Net.Security test stabilization Commit migrated from dotnet/corefx@53f1d8c
The following tests have been used:
Most of below bugs were potentially fixed by #7800 at least in part. Other test-code fixes to issues discovered during stress tests have been added to this PR.
Fixes #4467 #5283 #5284 #5991.
@davidsh @stephentoub @ericeil PTAL
/cc @himadrisarkar