-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Conversation
src/System.Reflection.Metadata/src/System/Reflection/Internal/Utilities/BitArithmetic.cs
Outdated
Show resolved
Hide resolved
src/System.Reflection.Metadata/src/System/Reflection/Internal/Utilities/BitArithmetic.cs
Outdated
Show resolved
Hide resolved
Looks like I may need to fix code depending on target.
|
Yes, this will likely be required until |
Adding The real problem is that |
Should I close this PR then - I am not sure it's worth it? |
I think the change in |
OK, manually reverted changes to |
All the NetFx targets are going to have the same problem. I don't think multi-targeting is worth it in this case since after inlining it has no functional benefit. It's really just about pretty code. |
Ok, I have not realized that |
Update known callsites in
CoreFX
to useBitOperations
See #35606
And #34917
cc @tannergooding, @jkotas