This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
SqlConnection timeout test is ported #26306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corivera
approved these changes
Jan 12, 2018
|
ConnectionTimeoutTestWithThread appears to be causing all PRs to fail on Windows. |
|
I will disable the test. @geleems please investigate. |
|
The timeout was set 5 seconds, and cutoff time for valid elapsed time was set 6 seconds. It seems some elapsed time were slightly over 6 seconds in some environment, which causes the PR failures. |
|
I have seen timeouts/sleeps be several times longer than you expect, depending on the machine, the load etc. Eg., if something is supposed to return in 5 secs you would want to wait for 30 secs to be safe. And there is no reliable way of knowing that what you're waiting on did not attempt to wait for longer. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Commit migrated from dotnet/corefx@cf191eb
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The connection timeout unit test that had been merged to release/2.0.0 branch is to be ported to master branch.