Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API diff between .NET 8.0 Preview 4 and .NET 8 Preview 5 #8546

Merged
merged 5 commits into from
Jun 20, 2023
Merged

API diff between .NET 8.0 Preview 4 and .NET 8 Preview 5 #8546

merged 5 commits into from
Jun 20, 2023

Conversation

carlossanlop
Copy link
Member

Known issues:

  • The AsmDiff tool sometimes skips adding { or {}. Please add a GitHub suggestion to correct it. arcade#10981
  • The AsmDiff tool shows APIs with decorating attribute changes as removed and re-added, instead of showing only the API. Please ignore this, it might be confusing but technically it's not incorrect. I have an issue to track this: arcade#13814

Repos area owners:

Libraries area owners:

  • System.Buffers: @dotnet/area-system-buffers
  • System.Collections: @dotnet/area-system-collections
  • System.ComponentModel.DataAnnotations: @dotnet/area-system-componentmodel-dataannotations
  • System.ComponentModel: @dotnet/area-system-componentmodel
  • System.Diagnostics.Metric: @tommcdon @noahfalk
  • System.Diagnostics.Process: @dotnet/area-system-diagnostics-process
  • System.Linq: @dotnet/area-system-linq
  • @System: @dotnet/area-system-runtime @dotnet/area-system-memory
  • System.Net: @dotnet/ncl
  • System.Reflection.Emit: @dotnet/area-system-reflection-emit
  • System.Reflection.Metadata.Ecma335: @dotnet/area-system-reflection-metadata
  • System.Runtime.InteropServices: @dotnet/interop-contrib
  • System.Runtime.Intrinsics: @dotnet/area-system-runtime-intrinsics
  • System.Security: @dotnet/area-system-security
  • System.Text.Json: @dotnet/area-system-text-json
  • System.Text: @dotnet/area-system-text-encoding
  • System.Web: @Rick-Anderson
  • System.Xml: @dotnet/area-system-xml

@carlossanlop carlossanlop self-assigned this Jun 15, 2023
tannergooding
tannergooding reviewed Jun 15, 2023
View reviewed changes
...otes/8.0/preview/api-diff/preview5/Microsoft.NETCore.App/8.0-preview5_System.Buffers.Text.md
# System.Buffers.Text

``` diff
namespace System.Buffers.Text {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.Buffers LGTM

CC. @dotnet/area-system-buffers

tannergooding
tannergooding reviewed Jun 15, 2023
View reviewed changes
...eview/api-diff/preview5/Microsoft.NETCore.App/8.0-preview5_System.Runtime.Intrinsics.Wasm.md
@@ -0,0 +1,120 @@
# System.Runtime.Intrinsics.Wasm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.Runtime.Intrinsics.Wasm LGTM

CC. @radekdoulik

tannergooding
tannergooding reviewed Jun 15, 2023
View reviewed changes
...review/api-diff/preview5/Microsoft.NETCore.App/8.0-preview5_System.Runtime.Intrinsics.X86.md
@@ -0,0 +1,275 @@
# System.Runtime.Intrinsics.X86
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.Runtime.Intrinsics.X86 LGTM

CC. @dotnet/area-system-runtime-intrinsics, @dotnet/avx512-contrib

tannergooding
tannergooding reviewed Jun 15, 2023
View reviewed changes
release-notes/8.0/preview/api-diff/preview5/Microsoft.NETCore.App/8.0-preview5_System.md
@@ -0,0 +1,33 @@
# System
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System LGTM.

CC. @dotnet/area-system-runtime

tannergooding
tannergooding approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@tannergooding tannergooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and signed-off on my areas

@tarekgh
Copy link
Member

tarekgh commented Jun 15, 2023

System.Diagnostics.Metrics LGTM.

eiriktsarpalis
eiriktsarpalis approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STJ changes LGTM.

dreddy-work
dreddy-work reviewed Jun 15, 2023
View reviewed changes
Copy link
Member

@dreddy-work dreddy-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest of WinForms LGTM.

adamsitnik
adamsitnik approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.Diagnostics.Process LGTM

@carlossanlop carlossanlop merged commit 2a3a6e4 into dotnet:main Jun 20, 2023
@carlossanlop carlossanlop deleted the ApiDiffPreview5 branch June 20, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreddy-work dreddy-work dreddy-work left review comments

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

@adamsitnik adamsitnik adamsitnik approved these changes

@tannergooding tannergooding tannergooding approved these changes

@rbhanda rbhanda Awaiting requested review from rbhanda rbhanda is a code owner

@leecow leecow Awaiting requested review from leecow leecow is a code owner

Assignees

@carlossanlop carlossanlop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@carlossanlop @tarekgh @eiriktsarpalis @adamsitnik @tannergooding @dreddy-work